From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] block/nbd: merge NBDClientSession struct back to BDRVNBDState
Date: Thu, 13 Jun 2019 18:06:10 +0200 [thread overview]
Message-ID: <8ce11b07-91b3-df46-53f1-7de34e9bb26e@redhat.com> (raw)
In-Reply-To: <c03ff39b-5e8f-ed0a-d33c-2d2d4919cd33@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 597 bytes --]
On 13.06.19 17:16, Eric Blake wrote:
> On 6/11/19 5:27 AM, Vladimir Sementsov-Ogievskiy wrote:
>> No reason to keep it separate, it differs from others block driver
>> behavior and therefor confuses. Instead of generic
>
> s/therefor/therefore/ (both spellings are valid, but the former looks
> archaic)
The things you teach me.
I will happily use “therefor” from now on whenever not too inappropriate.
(I like how Wiktionary notes that “therefor” is an anagram of
“therfore”. That one looks nice, too. I suppose I will just switch
between both at random.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-06-13 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:27 [Qemu-devel] [PATCH 0/3] nbd: merge block/nbd.c and block/nbd-client.c Vladimir Sementsov-Ogievskiy
2019-06-11 10:27 ` [Qemu-devel] [PATCH 1/3] block/nbd-client: drop stale logout Vladimir Sementsov-Ogievskiy
2019-06-13 14:28 ` Eric Blake
2019-06-11 10:27 ` [Qemu-devel] [PATCH 2/3] block/nbd: merge nbd-client.* to nbd.c Vladimir Sementsov-Ogievskiy
2019-06-13 14:53 ` Eric Blake
2019-06-11 10:27 ` [Qemu-devel] [PATCH 3/3] block/nbd: merge NBDClientSession struct back to BDRVNBDState Vladimir Sementsov-Ogievskiy
2019-06-13 15:16 ` Eric Blake
2019-06-13 15:20 ` Vladimir Sementsov-Ogievskiy
2019-06-13 16:06 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce11b07-91b3-df46-53f1-7de34e9bb26e@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).