From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
qemu-devel@nongnu.org, jasowang@redhat.com
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] slirp: Allow non-local DNS address when restrict is off
Date: Tue, 1 Oct 2019 11:31:19 +0200 [thread overview]
Message-ID: <8ce50d6b-094a-5cef-58fc-56123d8f2e4f@redhat.com> (raw)
In-Reply-To: <b49bd2a3-5280-136a-cc35-3d7c14b0a19c@redhat.com>
On 01/10/2019 11.04, Philippe Mathieu-Daudé wrote:
> Hi Samuel,
>
> On 9/29/19 8:13 PM, Samuel Thibault wrote:
>> This can be used to set a DNS server to be used by the guest which is
>> different from the one configured on the host.
>>
>> This fixes LP 1010484.
>
> Wow, 7 years old...
>
> Can you use this format, easier to understand for newcomers:
>
> Fixes: https://bugs.launchpad.net/qemu/+bug/1010484
That should be "Buglink:" instead. "Fixes:" is for referencing previous
commits. See our submit-a-patch page for more information:
https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
Thomas
next prev parent reply other threads:[~2019-10-01 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 18:13 [PATCH] slirp: Allow non-local DNS address when restrict is off Samuel Thibault
2019-09-29 18:26 ` Marc-André Lureau
2019-10-01 9:04 ` Philippe Mathieu-Daudé
2019-10-01 9:31 ` Thomas Huth [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-01 15:39 Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce50d6b-094a-5cef-58fc-56123d8f2e4f@redhat.com \
--to=thuth@redhat.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).