qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Roman Kagan <rvkagan@yandex-team.ru>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	yc-core@yandex-team.ru, Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH for-6.0 1/2] block/nbd: fix channel object leak
Date: Sat, 10 Apr 2021 10:43:25 +0300	[thread overview]
Message-ID: <8cebb4ce-7add-18a4-52f1-d5d6d2920a8f@virtuozzo.com> (raw)
In-Reply-To: <20210409160406.1800272-2-rvkagan@yandex-team.ru>

09.04.2021 19:04, Roman Kagan wrote:
> nbd_free_connect_thread leaks the channel object if it hasn't been
> stolen.
> 
> Unref it and fix the leak.
> 
> Signed-off-by: Roman Kagan<rvkagan@yandex-team.ru>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

-- 
Best regards,
Vladimir


  reply	other threads:[~2021-04-10  7:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 16:04 [PATCH for-6.0 0/2] block/nbd: assorted bugfixes Roman Kagan
2021-04-09 16:04 ` [PATCH for-6.0 1/2] block/nbd: fix channel object leak Roman Kagan
2021-04-10  7:43   ` Vladimir Sementsov-Ogievskiy [this message]
2021-04-09 16:04 ` [PATCH for-6.0 2/2] block/nbd: ensure ->connection_thread is always valid Roman Kagan
2021-04-10  8:06   ` Vladimir Sementsov-Ogievskiy
2021-04-10  8:38     ` Vladimir Sementsov-Ogievskiy
2021-04-10  9:56       ` Vladimir Sementsov-Ogievskiy
2021-04-10 12:20         ` Roman Kagan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cebb4ce-7add-18a4-52f1-d5d6d2920a8f@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rvkagan@yandex-team.ru \
    --cc=yc-core@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).