From: Shivam Kumar <shivam.kumar1@nutanix.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, peterx@redhat.com, david@redhat.com,
quintela@redhat.com, dgilbert@redhat.com, kvm@vger.kernel.org,
Shaju Abraham <shaju.abraham@nutanix.com>,
Manish Mishra <manish.mishra@nutanix.com>,
Anurag Madnawat <anurag.madnawat@nutanix.com>
Subject: Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus
Date: Tue, 22 Nov 2022 09:30:14 +0530 [thread overview]
Message-ID: <8cf78246-d00d-dbab-7e67-0ba09300e6ed@nutanix.com> (raw)
In-Reply-To: <dcaf828f-5959-e49e-a854-632814772cc1@linaro.org>
On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 20/11/22 23:54, Shivam Kumar wrote:
>> +
>> +void dirty_quota_migration_start(void)
>> +{
>> + if (!kvm_state->dirty_quota_supported) {
>
> You are accessing an accelerator-specific variable in an
> accelerator-agnostic file, this doesn't sound correct.
>
> You might introduce some hooks in AccelClass and implement them in
> accel/kvm/. See for example gdbstub_supported_sstep_flags() and
> kvm_gdbstub_sstep_flags().
>
Ack.
Thanks,
Shivam
next prev parent reply other threads:[~2022-11-22 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 22:54 [RFC PATCH 0/1] QEMU: Dirty quota-based throttling of vcpus Shivam Kumar
2022-11-20 22:54 ` [RFC PATCH 1/1] " Shivam Kumar
2022-11-21 11:35 ` Philippe Mathieu-Daudé
2022-11-22 4:00 ` Shivam Kumar [this message]
2023-02-13 9:17 ` Shivam Kumar
2022-12-06 5:48 ` [RFC PATCH 0/1] QEMU: " Shivam Kumar
2022-12-06 16:00 ` Peter Xu
2022-12-06 17:29 ` Hyman Huang
2022-12-18 19:12 ` Shivam Kumar
2022-12-19 14:19 ` Hyman Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cf78246-d00d-dbab-7e67-0ba09300e6ed@nutanix.com \
--to=shivam.kumar1@nutanix.com \
--cc=anurag.madnawat@nutanix.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=manish.mishra@nutanix.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shaju.abraham@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).