From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: [Qemu-devel] [PATCH v2 3/4] qemu-iotests: qemu-io tests update for block-commit (040)
Date: Tue, 16 Oct 2012 10:44:37 -0400 [thread overview]
Message-ID: <8cfe5b0bc3ef6f3dab2fc444fa491ada64bbb52f.1350398238.git.jcody@redhat.com> (raw)
In-Reply-To: <cover.1350398238.git.jcody@redhat.com>
In-Reply-To: <cover.1350398238.git.jcody@redhat.com>
Some of the error messages put out by block-commit have changed
slightly, which causes 2 tests cases for block-commit to fail.
This patch updates the test cases to look for the correct error
output.
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
tests/qemu-iotests/040 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index 258e7ea..0fa6441 100755
--- a/tests/qemu-iotests/040
+++ b/tests/qemu-iotests/040
@@ -111,7 +111,7 @@ class TestSingleDrive(ImageCommitTestCase):
self.assert_no_active_commit()
result = self.vm.qmp('block-commit', device='drive0', top='%s' % backing_img, base='%s' % backing_img)
self.assert_qmp(result, 'error/class', 'GenericError')
- self.assert_qmp(result, 'error/desc', 'Invalid files for merge: top and base are the same')
+ self.assert_qmp(result, 'error/desc', 'Base \'%s\' not found' % backing_img)
def test_top_invalid(self):
self.assert_no_active_commit()
@@ -135,7 +135,7 @@ class TestSingleDrive(ImageCommitTestCase):
self.assert_no_active_commit()
result = self.vm.qmp('block-commit', device='drive0', top='%s' % backing_img, base='%s' % mid_img)
self.assert_qmp(result, 'error/class', 'GenericError')
- self.assert_qmp(result, 'error/desc', 'Base (%(1)s) is not reachable from top (%(2)s)' % {"1" : mid_img, "2" : backing_img})
+ self.assert_qmp(result, 'error/desc', 'Base \'%s\' not found' % mid_img)
def test_top_omitted(self):
self.assert_no_active_commit()
--
1.7.11.4
next prev parent reply other threads:[~2012-10-16 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 14:44 [Qemu-devel] [PATCH v2 0/4] block-commit fixes Jeff Cody
2012-10-16 14:44 ` [Qemu-devel] [PATCH v2 1/4] block: make bdrv_find_backing_image compare canonical filenames Jeff Cody
2012-10-16 15:12 ` Eric Blake
2012-10-16 15:40 ` Jeff Cody
2012-10-16 14:44 ` [Qemu-devel] [PATCH v2 2/4] block: in commit, determine base image from the top image Jeff Cody
2012-10-16 15:22 ` Eric Blake
2012-10-16 15:31 ` Jeff Cody
2012-10-16 15:35 ` Eric Blake
2012-10-16 14:44 ` Jeff Cody [this message]
2012-10-16 14:44 ` [Qemu-devel] [PATCH v2 4/4] qemu-iotests: add relative backing file tests for block-commit (040) Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cfe5b0bc3ef6f3dab2fc444fa491ada64bbb52f.1350398238.git.jcody@redhat.com \
--to=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).