From: Robert Hoo <robert.hoo.linux@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, mst@redhat.com,
marcel.apfelbaum@gmail.com
Subject: Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback
Date: Mon, 13 Nov 2023 21:03:06 +0800 [thread overview]
Message-ID: <8cff6965-5f45-76d0-1b56-4f9a53474ec7@gmail.com> (raw)
In-Reply-To: <53512cf6-b595-4cff-a1f2-6f1dd2c6621a@linaro.org>
On 11/13/2023 6:05 PM, Philippe Mathieu-Daudé wrote:
> Hi Robert,
>
> On 13/11/23 09:13, Robert Hoo wrote:
>> In the rollback in msix_set_vector_notifiers(), original patch forgot to
>> undo msix_vector_poll_notifier pointer.
>
> Out of curiosity, nobody complained during 11 years, so in which
> use case did you notice this?
>
Hi Philippe,
I stumbled upon this when looking into another issue.
I think, thanks to the caller's very standardized use, the omission has never
been exposed.
prev parent reply other threads:[~2023-11-13 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 8:13 [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback Robert Hoo
2023-11-13 10:05 ` Philippe Mathieu-Daudé
2023-11-13 13:03 ` Robert Hoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cff6965-5f45-76d0-1b56-4f9a53474ec7@gmail.com \
--to=robert.hoo.linux@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).