From: Richard Henderson <rth@twiddle.net>
To: "Emilio G. Cota" <cota@braap.org>, qemu-devel@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase
Date: Thu, 15 Feb 2018 07:13:48 -0800 [thread overview]
Message-ID: <8d09f7ec-c8de-d9fb-21c3-925e1c1a4247@twiddle.net> (raw)
In-Reply-To: <1518664462-2960-3-git-send-email-cota@braap.org>
On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> A couple of notes:
>
> - removed ctx->nip in favour of base->pc_next. Yes, it is annoying,
> but didn't want to waste its 4 bytes.
>
> - ctx->singlestep_enabled does a lot more than
> base.singlestep_enabled; this confused me at first.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> target/ppc/translate.c | 129 +++++++++++++++++++-----------------
> target/ppc/translate/dfp-impl.inc.c | 16 ++---
> target/ppc/translate_init.c | 32 ++++-----
> 3 files changed, 91 insertions(+), 86 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-02-15 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 3:14 [Qemu-devel] [PATCH 0/3] target/ppc: convert to generic translation loop Emilio G. Cota
2018-02-15 3:14 ` [Qemu-devel] [PATCH 1/3] translator: add retcode to translator_loop_temp_check Emilio G. Cota
2018-02-15 15:09 ` Richard Henderson
2018-02-15 16:24 ` Emilio G. Cota
2018-02-15 3:14 ` [Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase Emilio G. Cota
2018-02-15 15:13 ` Richard Henderson [this message]
2018-02-15 3:14 ` [Qemu-devel] [PATCH 3/3] target/ppc: convert to TranslatorOps Emilio G. Cota
2018-02-15 15:20 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d09f7ec-c8de-d9fb-21c3-925e1c1a4247@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=cota@braap.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).