From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emLEh-00035d-Bg for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:14:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emLEg-0001NQ-Er for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:14:11 -0500 Sender: Richard Henderson References: <1518664462-2960-1-git-send-email-cota@braap.org> <1518664462-2960-3-git-send-email-cota@braap.org> From: Richard Henderson Message-ID: <8d09f7ec-c8de-d9fb-21c3-925e1c1a4247@twiddle.net> Date: Thu, 15 Feb 2018 07:13:48 -0800 MIME-Version: 1.0 In-Reply-To: <1518664462-2960-3-git-send-email-cota@braap.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org Cc: David Gibson , Alexander Graf , qemu-ppc@nongnu.org On 02/14/2018 07:14 PM, Emilio G. Cota wrote: > A couple of notes: > > - removed ctx->nip in favour of base->pc_next. Yes, it is annoying, > but didn't want to waste its 4 bytes. > > - ctx->singlestep_enabled does a lot more than > base.singlestep_enabled; this confused me at first. > > Signed-off-by: Emilio G. Cota > --- > target/ppc/translate.c | 129 +++++++++++++++++++----------------- > target/ppc/translate/dfp-impl.inc.c | 16 ++--- > target/ppc/translate_init.c | 32 ++++----- > 3 files changed, 91 insertions(+), 86 deletions(-) Reviewed-by: Richard Henderson r~