qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: ~_6d6178667269747a <maxfritz@me.com>,
	qemu-devel@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Gonglei <arei.gonglei@huawei.com>,
	zhenwei pi <pizhenwei@bytedance.com>,
	antischmock@googlemail.com
Subject: Re: [PATCH qemu 1/1] [meson.build] Add conditional dependency for libkeyutils
Date: Fri, 26 May 2023 09:34:14 +0200	[thread overview]
Message-ID: <8d0dfbed-91e7-ea7d-afe9-cc170de5ad79@redhat.com> (raw)
In-Reply-To: <168471463402.18155.3575359027429939965-1@git.sr.ht>


  Hi!

On 22/05/2023 02.12, ~_6d6178667269747a wrote:

There is something weird with your setup (sender name is "~_6d6178667269747a" ?)

> From: Max Fritz <antischmock@googlemail.com>
> 
> This modification enables better control over the inclusion of libkeyutils
> based on the configuration, enhancing the flexibility of the build system.
> 
> Signed-off-by: Max Fritz <antischmock@googlemail.com>
> ---
>   meson.build | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 0a5cdefd4d..206d4033bf 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1764,8 +1764,11 @@ if gnutls.found()
>     tasn1 = dependency('libtasn1',
>                        method: 'pkg-config')
>   endif
> -keyutils = dependency('libkeyutils', required: false,
> -                      method: 'pkg-config')
> +keyutils = not_found
> +if get_option('keyring').enabled()
> +  keyutils = dependency('libkeyutils', required: false,
> +                        method: 'pkg-config', kwargs: static_kwargs)
> +endif
>   
>   has_gettid = cc.has_function('gettid')

Please put the maintainer for the crypto/ folder for this into copy (done now).

  Thomas




  reply	other threads:[~2023-05-26  7:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  0:17 [PATCH qemu 0/1] [meson.build] Add conditional dependency for libkeyutils ~_6d6178667269747a
2023-05-22  0:12 ` [PATCH qemu 1/1] " ~_6d6178667269747a
2023-05-26  7:34   ` Thomas Huth [this message]
2023-05-26 10:32   ` Daniel P. Berrangé
2023-05-31 13:09   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d0dfbed-91e7-ea7d-afe9-cc170de5ad79@redhat.com \
    --to=thuth@redhat.com \
    --cc=antischmock@googlemail.com \
    --cc=arei.gonglei@huawei.com \
    --cc=berrange@redhat.com \
    --cc=maxfritz@me.com \
    --cc=pbonzini@redhat.com \
    --cc=pizhenwei@bytedance.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).