From: Jean-Louis Dupond <jean-louis@dupond.be>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/2] qcow2: queue discards when discard-no-unref enabled
Date: Fri, 29 Aug 2025 11:43:12 +0200 [thread overview]
Message-ID: <8d2033db-34e3-434a-aaae-22fe538ddbb6@dupond.be> (raw)
In-Reply-To: <20250513132628.1055549-1-jean-louis@dupond.be>
On 13/05/2025 15:26, Jean-Louis Dupond wrote:
> Partially based on the proposal of Andrey in
> https://patchew.org/QEMU/20240913163942.423050-1-andrey.drobyshev@virtuozzo.com/
> Split up this from the rest might get it merged a bit quicker hopefully :)
>
> Since the implementation of discard-no-unref, we did not queue the discards correctly
> when discard-no-unref was enabled.
>
> Jean-Louis Dupond (2):
> qcow2: rename update_refcount_discard to queue_discard
> qcow2: put discards in discard queue when discard-no-unref is enabled
>
> block/qcow2-cluster.c | 16 ++++++----------
> block/qcow2-refcount.c | 25 +++++++++++++++++++++----
> block/qcow2.h | 4 ++++
> 3 files changed, 31 insertions(+), 14 deletions(-)
>
This was already reviewed.
Reviewed-by: Eric Blake <eblake@redhat.com>
Any chance on getting this merged?
Thanks
Jean-Louis
prev parent reply other threads:[~2025-08-30 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 13:26 [PATCH v2 0/2] qcow2: queue discards when discard-no-unref enabled Jean-Louis Dupond
2025-05-13 13:26 ` [PATCH v2 1/2] qcow2: rename update_refcount_discard to queue_discard Jean-Louis Dupond
2025-05-15 19:42 ` Eric Blake
2025-05-13 13:26 ` [PATCH v2 2/2] qcow2: put discards in discard queue when discard-no-unref is enabled Jean-Louis Dupond
2025-05-15 19:47 ` Eric Blake
2025-08-29 9:43 ` Jean-Louis Dupond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d2033db-34e3-434a-aaae-22fe538ddbb6@dupond.be \
--to=jean-louis@dupond.be \
--cc=alexander.ivanov@virtuozzo.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).