Re: [Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events

[Jack Schwartz <jack.schwartz@oracle.com>]

Hi Kevin.

Thanks for your feedback.

Looks like my team's project plans have changed, and there is no need to 
pursue this further.  We can work with the existing reason string.

         Thanks,
         Jack

On 01/09/18 02:24, Kevin Wolf wrote:
> Am 08.01.2018 um 20:57 hat Jack Schwartz geschrieben:
>> Hi Kevin.
>>
>> On 2017-12-22 05:52, Kevin Wolf wrote:
>>> Am 22.12.2017 um 01:11 hat Jack Schwartz geschrieben:
>>>> BLOCK_IO_ERROR events currently contain a "reason" string which is
>>>> strerror(errno) of the error.  This enhancement provides those events with
>>>> the numeric errno value as well, since it is easier to parse for error type
>>>> than a string.
>>>>
>>>> Signed-off-by: Jack Schwartz<jack.schwartz@oracle.com>
>>>> Reviewed-by: Konrad Rzeszutek Wilk<konrad.wilk@oracle.com>
>>>> Reviewed-by: Karl Heubaum<karl.heubaum@oracle.com>
>>> Apart from the technical details that Eric mentioed, I wonder what is
>>> your use case for this?
>> We have thousands of servers in our cloud, and would like to closely monitor
>> for different kinds of disk errors without parsing the non-machine-readable
>> error string.
> So do you actually care about the semantical difference between, say,
> EINVAL and EIO, and treat them differently in the monitoring? To be
> honest, I can't see anything useful you could do with this information
> because there are so many possible causes for each of the error codes.
>
> Because if the only thing you want to do with them is to log them in
> different categories, you can use the error strings without parsing
> them.
>
>>> Exposing errors in a machine readable form was discussed earlier,
>> OK, found it.  April of 2010.
>>
>> Upshot of discussion: exposing naked errnos are platform dependent.
> Right, that's what Eric mentioned.
>
>>>    and
>>> the result was that nobody had an actual use for error codes other than
>>> presenting the right error message to the user - which the error string
>>> already achieves.
>> Given the platform independence requirement, exposing errors to clients is
>> not that simple given that different OSs use different errno values.  Other
>> options/considerations than exposing naked errno values:
>>
>> - Having a platform-independent enumeration of errors, as Eric suggested.
>> This would have to explicitly set an enumerated value for each individual
>> errno we are interested in.  It would be returned in a field that ~parallels
>> the "reason" string.  This should be OK since for BLOCK_IO_ERROR events we
>> could limit values to just storage device errors plus a default "other";
>> otherwise this could be hard to maintain.
> But what are "storage device errors"? Can't we get more or less any
> error while processing an I/O request?
>
>> - The strerror strings cannot be used because they can change with locale.
>> (This also assumes the strings are identical for given errnos
>> cross-platform, and that there are no typos - which are not automatically
>> checked-for.)
> You mean when you aggregate errors from multiple different hosts running
> on different platforms and where you don't control the locale?
>
> But cross-platform, even the exact numeric error codes you get may
> differ, so they become even less meaningful than they already are on a
> single platform.
>
> Kevin
>