From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: Peter Lieven <pl@kamp.de>, "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete
Date: Fri, 21 Apr 2017 12:43:35 +0300 [thread overview]
Message-ID: <8d45e88c-f19e-65fc-937e-d1547b50c63c@virtuozzo.com> (raw)
In-Reply-To: <8f297f9f-8aa2-bca8-d99e-dc9fc767abf2@kamp.de>
On 04/21/2017 12:18 PM, Peter Lieven wrote:
> Am 18.04.2017 um 12:27 schrieb Denis V. Lunev:
>> From: Anton Nefedov <anton.nefedov@virtuozzo.com>
>>
>> We should wait for other coroutines on error path, i.e. one of coroutines
>> terminates with i/o error, before cleaning the common structures. In the
>> other case we would crash in a lot of different places. This behaviour
>> was introduced by commit 2d9187bc65.
>>
>> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Peter Lieven <pl@kamp.de>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> CC: Max Reitz <mreitz@redhat.com>
>
> Cc: qemu-stable@nongnu.org
>
> This should go into 2.9.1
>
> Peter
>
Actually I'm afraid the patch is incorrect.. The erroneous coroutine
bails out without reentering its possible dependent coroutine so it (and
the following dependents) will never finish.
I'll send out the 2nd version soon
/Anton
prev parent reply other threads:[~2017-04-21 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 10:27 [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete Denis V. Lunev
2017-04-18 11:22 ` Peter Lieven
2017-04-21 9:18 ` Peter Lieven
2017-04-21 9:43 ` Anton Nefedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d45e88c-f19e-65fc-937e-d1547b50c63c@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).