qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Jiajie Chen <c@jia.je>, qemu-devel@nongnu.org
Cc: gaosong@loongson.cn
Subject: Re: [PATCH 00/11] Lower TCG vector ops to LSX
Date: Mon, 28 Aug 2023 10:29:44 -0700	[thread overview]
Message-ID: <8d4941d2-77e3-f9de-302f-b3f9d14141dc@linaro.org> (raw)
In-Reply-To: <20230828152009.352048-1-c@jia.je>

On 8/28/23 08:19, Jiajie Chen wrote:
> This patch series allows qemu to utilize LSX instructions on LoongArch
> machines to execute TCG vector ops.
> 
> Jiajie Chen (11):
>    tcg/loongarch64: Import LSX instructions
>    tcg/loongarch64: Lower basic tcg vec ops to LSX
>    tcg/loongarch64: Lower cmp_vec to vseq/vsle/vslt
>    tcg/loongarch64: Lower add/sub_vec to vadd/vsub
>    tcg/loongarch64: Lower vector bitwise operations
>    tcg/loongarch64: Lower neg_vec to vneg
>    tcg/loongarch64: Lower mul_vec to vmul
>    tcg/loongarch64: Lower vector min max ops
>    tcg/loongarch64: Lower vector saturated ops
>    tcg/loongarch64: Lower vector shift vector ops
>    tcg/loongarch64: Lower bitsel_vec to vbitsel
> 
>   tcg/loongarch64/tcg-insn-defs.c.inc  | 6251 +++++++++++++++++++++++++-
>   tcg/loongarch64/tcg-target-con-set.h |    5 +
>   tcg/loongarch64/tcg-target-con-str.h |    1 +
>   tcg/loongarch64/tcg-target.c.inc     |  414 +-
>   tcg/loongarch64/tcg-target.h         |   37 +-
>   tcg/loongarch64/tcg-target.opc.h     |   12 +
>   6 files changed, 6601 insertions(+), 119 deletions(-)
>   create mode 100644 tcg/loongarch64/tcg-target.opc.h

Looks very good at a first pass.

We should probably improve tcg_gen_not_vec to try NOR.  This would support loongarch64, 
and allow the special expansion in PPC and S390X to be removed.

It would be good to support TCG_TARGET_HAS_shi_vec using VSLLI/VSRLI/VSRAI.

It would be good to support TCG_TARGET_HAS_roti_vec and TCG_TARGET_HAS_rotv_vec.



r~


  parent reply	other threads:[~2023-08-28 17:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 15:19 [PATCH 00/11] Lower TCG vector ops to LSX Jiajie Chen
2023-08-28 15:19 ` [PATCH 01/11] tcg/loongarch64: Import LSX instructions Jiajie Chen
2023-08-28 15:19 ` [PATCH 02/11] tcg/loongarch64: Lower basic tcg vec ops to LSX Jiajie Chen
2023-08-28 16:57   ` Richard Henderson
2023-08-28 17:04     ` Jiajie Chen
2023-08-28 15:19 ` [PATCH 03/11] tcg/loongarch64: Lower cmp_vec to vseq/vsle/vslt Jiajie Chen
2023-08-28 17:08   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 04/11] tcg/loongarch64: Lower add/sub_vec to vadd/vsub Jiajie Chen
2023-08-28 17:13   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 05/11] tcg/loongarch64: Lower vector bitwise operations Jiajie Chen
2023-08-28 17:17   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 06/11] tcg/loongarch64: Lower neg_vec to vneg Jiajie Chen
2023-08-28 17:18   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 07/11] tcg/loongarch64: Lower mul_vec to vmul Jiajie Chen
2023-08-28 17:18   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 08/11] tcg/loongarch64: Lower vector min max ops Jiajie Chen
2023-08-28 17:19   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 09/11] tcg/loongarch64: Lower vector saturated ops Jiajie Chen
2023-08-28 17:20   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 10/11] tcg/loongarch64: Lower vector shift vector ops Jiajie Chen
2023-08-28 17:21   ` Richard Henderson
2023-08-28 15:19 ` [PATCH 11/11] tcg/loongarch64: Lower bitsel_vec to vbitsel Jiajie Chen
2023-08-28 17:22   ` Richard Henderson
2023-08-28 17:29 ` Richard Henderson [this message]
2023-08-28 19:39   ` [PATCH 00/11] Lower TCG vector ops to LSX Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d4941d2-77e3-f9de-302f-b3f9d14141dc@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=c@jia.je \
    --cc=gaosong@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).