Re: [PATCH v2 1/2] hw/ppc: Fix missing return on allocation failure

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 28/10/25 09:05, Shivang Upadhyay wrote:
> Fixes coverity (CID 1642026)
> 
> Cc: Aditya Gupta <adityag@linux.ibm.com>
> Cc: Harsh Prateek Bora <harshpb@linux.ibm.com>
> Link: https://lore.kernel.org/qemu-devel/CAFEAcA-SPmsnU1wzsWxBcFC=ZM_DDhPEg1N4iX9Q4bL1xOnwBg@mail.gmail.com/
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> ---
>   hw/ppc/spapr_fadump.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/spapr_fadump.c b/hw/ppc/spapr_fadump.c
> index fa3aeac94c..883a60cdcf 100644
> --- a/hw/ppc/spapr_fadump.c
> +++ b/hw/ppc/spapr_fadump.c
> @@ -234,6 +234,7 @@ static bool do_preserve_region(FadumpSection *region)
>           qemu_log_mask(LOG_GUEST_ERROR,

FWIW host heap exhaustion is not really a *guest* error, because the
guest can not control it.

>               "FADump: Failed allocating memory (size: %zu) for copying"
>               " reserved memory regions\n", FADUMP_CHUNK_SIZE);
> +        return false;
>       }
>   
>       num_chunks = ceil((src_len * 1.0f) / FADUMP_CHUNK_SIZE);