From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFB7FC54EBD for ; Mon, 9 Jan 2023 16:05:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEudD-0007Ss-Fe; Mon, 09 Jan 2023 11:04:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEudB-0007SJ-V9 for qemu-devel@nongnu.org; Mon, 09 Jan 2023 11:04:13 -0500 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEudA-0007OJ-Ba for qemu-devel@nongnu.org; Mon, 09 Jan 2023 11:04:13 -0500 Received: by mail-pj1-x102d.google.com with SMTP id m7-20020a17090a730700b00225ebb9cd01so13246493pjk.3 for ; Mon, 09 Jan 2023 08:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hDSGGa2mIec3Z/Eyh62lHcxtXQEkdf79o5GxRHENBpg=; b=NK7ovHYk83SGT5W8AxUehZpsJBxiWqIYf7o00fwX8TL/105XEXLWFcNmK9zvV672Wf U9EgqxQPAabMNAw2iOqM27DOUuXtchuhyx56H3Iq6BJ04PN+enUrHnG4Q3dlGE/R0cdw mP4He7oqSuRJd7JbwNTpTpoAr3Mp6FU6J8SD0n+AkWYhWxzUnnqvzPyAGpuNyipWWrpu 55yOGPaNveN1Uineys3qL1Gu88lLFdbMVpGTYxNeA2SheOFPWRE0azO6qJwbC5zuZ5uO hMqo+pAreKM644i56UUmDSL69KiU3BjJiT3LzqOJTSpaRZ8pM7DLYdETkWuWto9E6X1+ YKhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hDSGGa2mIec3Z/Eyh62lHcxtXQEkdf79o5GxRHENBpg=; b=jQo0vPLGyOYfn5nd7yjS0JffaZFS+/4LZkg8KcBB2LFEz9AKgp6EJEnz+PaotPFS71 M87mhBPr3wc3OgMaRFG5tCI4Pj/lb/8qnZtf+12V4SEBP6GQwNnPLQCpII2+qTpdNs1Y JDn5sk49h/pI6QkIchtFpsOxnaYsUr9LDpFpwGdMcaU8LfAXyIs1u1L/lnbZaOxHyYK7 z/U/1wwfnPRCPdkLe7D4MOOtCFlWKv2EbIzP0pOPpHhhs6543JkbUq5IA0r+OTZygsfJ 1iV3KZO+UD0B6BSkBr+T0yceephDPbSD8M52AGZbd3izksiHC73SVlMLzuEp8JSXxma9 SFFg== X-Gm-Message-State: AFqh2ko6U4HA3lPYAr3BjkIpHouy/z+ngh/6Oi6X0r4iGbJuqMOTZIl/ DVdN45hXfNBbD5nbP/rX6D/wrA== X-Google-Smtp-Source: AMrXdXt7BZfuJ0YeM8omzk6LQmFFl4tdlJYcllBNIitnocEwwps+zwwpnWRKg3lOLP66s4NstgMKzQ== X-Received: by 2002:a17:902:9895:b0:191:282:5d72 with SMTP id s21-20020a170902989500b0019102825d72mr79790370plp.51.1673280250004; Mon, 09 Jan 2023 08:04:10 -0800 (PST) Received: from ?IPV6:2602:47:d48c:8101:a909:891c:953d:a6b0? ([2602:47:d48c:8101:a909:891c:953d:a6b0]) by smtp.gmail.com with ESMTPSA id t2-20020a1709027fc200b00192f9991e51sm6184362plb.251.2023.01.09.08.04.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 08:04:09 -0800 (PST) Message-ID: <8d60f5b9-9fa9-2c21-d72e-609bfbaecf39@linaro.org> Date: Mon, 9 Jan 2023 08:04:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] target/riscv: Use TARGET_FMT_lx for env->mhartid Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Bin Meng , Alistair Francis , qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Thomas Huth , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20230109152655.340114-1-bmeng@tinylab.org> <6e3de50d-38d9-b5ba-dac4-91352be8b96b@linaro.org> From: Richard Henderson In-Reply-To: <6e3de50d-38d9-b5ba-dac4-91352be8b96b@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/9/23 07:47, Philippe Mathieu-Daudé wrote: > On 9/1/23 16:26, Bin Meng wrote: >> env->mhartid is currently casted to long before printed, which drops >> the high 32-bit for rv64 on 32-bit host. Use TARGET_FMT_lx instead. > > Oh, a 32-bit host user! > >> Signed-off-by: Bin Meng >> --- >> >>   target/riscv/cpu.c | 6 +++--- >>   1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c >> index cc75ca7667..a5ed6d3f63 100644 >> --- a/target/riscv/cpu.c >> +++ b/target/riscv/cpu.c >> @@ -660,9 +660,9 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp) >>               (env->priv_ver < isa_edata_arr[i].min_version)) { >>               isa_ext_update_enabled(cpu, &isa_edata_arr[i], false); >>   #ifndef CONFIG_USER_ONLY >> -            warn_report("disabling %s extension for hart 0x%lx because " >> -                        "privilege spec version does not match", >> -                        isa_edata_arr[i].name, (unsigned long)env->mhartid); >> +            warn_report("disabling %s extension for hart 0x" TARGET_FMT_lx >> +                        " because privilege spec version does not match", >> +                        isa_edata_arr[i].name, env->mhartid); > > Could we cast it to vaddr instead? I'm trying to remove target_[u]long > from hw/ and restrict it to the target/ directory. Per "exec/cpu-common.h": This isn't in hw/, it's in target/. And no, it's a target-width register. r~