From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7DB1C7EE26 for ; Sun, 21 May 2023 11:16:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0h1w-0000HC-7J; Sun, 21 May 2023 07:15:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0h1v-0000Gq-8Y for qemu-devel@nongnu.org; Sun, 21 May 2023 07:15:15 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q0h1t-0004gS-Gf for qemu-devel@nongnu.org; Sun, 21 May 2023 07:15:14 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f420618d5bso30619145e9.1 for ; Sun, 21 May 2023 04:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684667712; x=1687259712; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S7lCt1F+L+Sdvv92ThgE7G1ptCNi2zM217m0D08ErHo=; b=IQpNCPav85qGHNro+7zBckqzY6IkPGWwui3Zo6nP80X6yd8jQVuvaB8QO6anbsfEtI 3CmsVM5U4MGyOdbwOijmXJo4WFr2/P6gCLESRZDj49vEFpMSqge1dhRHEhdf0oTfu4sO v8dTljS6sdMvrmoQyrn7Ek8TuFdhn2elv40duKCJwJgw5sT9o7Q+a+3ybrS7iEcdb3/W jjD2RMUyI3NhBjHTQAbuBcnJDQz6Oq7VPF6fawi1N85HhGpW6V96bxQLWdwQpmgAuTsT T9tUBIGq67Im95BPvUkJqP/Ti17CuSmKglpY4btlq1aJaWe4pUzlRBQIj0miEubPF7qw OKkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684667712; x=1687259712; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S7lCt1F+L+Sdvv92ThgE7G1ptCNi2zM217m0D08ErHo=; b=fhDcxT9ADJnznG/jhtEcc6ERJuxU1Mvp7dFIymeU353lU4nNfmOj++F2xrtHa4CyOS cq6py3SPF4Du5Eu6cH23AVDv8/Ep7DU+9Iof+zsBUIVJyFR8t+O8VXKQOytU3p7r/ipS EBcsqrs1MD/08crNITiyI4u1yqXkN6aTg3N8tWlug796w1kl8sYdfUgq7pZce8/hu1Pc CqrLtryk1fGW0WPWSnclMwSRqR20rLZuzSZ/Z2kzUnGlSP4OE0IsHdRc4SVyRULo5ZNz 02Pj1FtiRrXiGAbuPYsd4edcnKrxABK/tbYbt/T6LzzvFpMF5ZG6quh7vC5rM2yrta5g NE3g== X-Gm-Message-State: AC+VfDxwEh2O5xSWuNDntHg4Az+nEc2XIlDCaezYO+aESLqrXFIAdzlp bQhJ9CxBUgOuDw8Bloq+msjgRw== X-Google-Smtp-Source: ACHHUZ7IUJSSOQvAdmPhKGN0vdIAPh5uY7nnvJkDGaNbT8s6dRz67jSlRaBZGOKEsOsIP+FLJRREGg== X-Received: by 2002:a1c:7c08:0:b0:3f5:4d4:4edb with SMTP id x8-20020a1c7c08000000b003f504d44edbmr5189436wmc.21.1684667711840; Sun, 21 May 2023 04:15:11 -0700 (PDT) Received: from [192.168.69.115] ([176.176.152.177]) by smtp.gmail.com with ESMTPSA id l10-20020a05600c27ca00b003f4290720d0sm8029684wmb.47.2023.05.21.04.15.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 May 2023 04:15:11 -0700 (PDT) Message-ID: <8d6e67d7-52c0-aa60-76cb-bf70d586cf7a@linaro.org> Date: Sun, 21 May 2023 13:15:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 16/27] accel/tcg: Unify cpu_{ld,st}*_{be,le}_mmu Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Mark Cave-Ayland , Artyom Tarasenko References: <20230520162634.3991009-1-richard.henderson@linaro.org> <20230520162634.3991009-17-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230520162634.3991009-17-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.098, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Richard, On 20/5/23 18:26, Richard Henderson wrote: > With the current structure of cputlb.c, there is no difference > between the little-endian and big-endian entry points, aside > from the assert. Unify the pairs of functions. > > The only use of the functions with explicit endianness was in > target/sparc64, and that was only to satisfy the assert. I'm having hard time to follow all the handling of the various ASI definitions from target/sparc/asi.h. ... > Signed-off-by: Richard Henderson > --- > include/exec/cpu_ldst.h | 58 ++----- > accel/tcg/cputlb.c | 122 +++----------- > accel/tcg/user-exec.c | 322 ++++++++++-------------------------- > target/arm/tcg/m_helper.c | 4 +- > target/sparc/ldst_helper.c | 18 +- > accel/tcg/ldst_common.c.inc | 24 +-- > 6 files changed, 137 insertions(+), 411 deletions(-) > diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c > index 7972d56a72..981a47d8bb 100644 > --- a/target/sparc/ldst_helper.c > +++ b/target/sparc/ldst_helper.c > @@ -1334,25 +1334,13 @@ uint64_t helper_ld_asi(CPUSPARCState *env, target_ulong addr, Shouldn't we propagate the ASI endianness? ... + memop |= (asi & 8) ? MO_LE : MO_BE; oi = make_memop_idx(memop, idx); switch (size) { case 1: > ret = cpu_ldb_mmu(env, addr, oi, GETPC()); > break; > case 2: > - if (asi & 8) { > - ret = cpu_ldw_le_mmu(env, addr, oi, GETPC()); > - } else { > - ret = cpu_ldw_be_mmu(env, addr, oi, GETPC()); > - } > + ret = cpu_ldw_mmu(env, addr, oi, GETPC()); > break; > case 4: > - if (asi & 8) { > - ret = cpu_ldl_le_mmu(env, addr, oi, GETPC()); > - } else { > - ret = cpu_ldl_be_mmu(env, addr, oi, GETPC()); > - } > + ret = cpu_ldl_mmu(env, addr, oi, GETPC()); > break; > case 8: > - if (asi & 8) { > - ret = cpu_ldq_le_mmu(env, addr, oi, GETPC()); > - } else { > - ret = cpu_ldq_be_mmu(env, addr, oi, GETPC()); > - } > + ret = cpu_ldq_mmu(env, addr, oi, GETPC()); > break; > default: > g_assert_not_reached(); Otherwise great simplification!