From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Priit Laes <plaes@plaes.org>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qom: Include qemu/fprintf-fn.h in cpu.h
Date: Wed, 26 Dec 2018 13:56:28 +0100 [thread overview]
Message-ID: <8d71a38b-f907-c959-0bb5-aed5b62f5652@redhat.com> (raw)
In-Reply-To: <20181226003722.31257-1-plaes@plaes.org>
On 12/26/18 1:37 AM, Priit Laes wrote:
> QOM cpu.h uses fprintf_function which requires Qemu's
> qemu/fprintf-fn.h header. Include it.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/qom/cpu.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 1396f53e5b..6d1ba53d72 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -26,6 +26,7 @@
> #include "exec/memattrs.h"
> #include "qapi/qapi-types-run-state.h"
> #include "qemu/bitmap.h"
> +#include "qemu/fprintf-fn.h"
> #include "qemu/rcu_queue.h"
> #include "qemu/queue.h"
> #include "qemu/thread.h"
>
next prev parent reply other threads:[~2018-12-26 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 0:37 [Qemu-devel] [PATCH] qom: Include qemu/fprintf-fn.h in cpu.h Priit Laes
2018-12-26 12:56 ` Philippe Mathieu-Daudé [this message]
2019-01-09 10:10 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d71a38b-f907-c959-0bb5-aed5b62f5652@redhat.com \
--to=philmd@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=plaes@plaes.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).