From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: libvir-list@redhat.com, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 3/3] hw/pci: Remove the "command_serr_enable" property
Date: Fri, 6 Dec 2019 11:21:40 +0100 [thread overview]
Message-ID: <8d71b68b-ac66-46ed-b9d6-e54d40b7cb88@redhat.com> (raw)
In-Reply-To: <20191205160652.23493-4-thuth@redhat.com>
On 05/12/19 17:06, Thomas Huth wrote:
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index db75c6dfd0..5b6ebd15c6 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -174,9 +174,6 @@ enum {
> #define QEMU_PCI_CAP_MULTIFUNCTION_BITNR 3
> QEMU_PCI_CAP_MULTIFUNCTION = (1 << QEMU_PCI_CAP_MULTIFUNCTION_BITNR),
>
> - /* command register SERR bit enabled */
> -#define QEMU_PCI_CAP_SERR_BITNR 4
> - QEMU_PCI_CAP_SERR = (1 << QEMU_PCI_CAP_SERR_BITNR),
> /* Standard hot plug controller. */
> #define QEMU_PCI_SHPC_BITNR 5
> QEMU_PCI_CAP_SHPC = (1 << QEMU_PCI_SHPC_BITNR),
I think it's okay to keep this enum.
Paolo
next prev parent reply other threads:[~2019-12-06 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 16:06 [PATCH 0/3] Remove deprecated pc-0.x machine types and related hacks Thomas Huth
2019-12-05 16:06 ` [PATCH 1/3] hw/i386: Remove the deprecated machines 0.12 up to 0.15 Thomas Huth
2019-12-05 22:00 ` [libvirt] " Eric Blake
2019-12-06 5:04 ` Thomas Huth
2019-12-06 5:51 ` Philippe Mathieu-Daudé
2019-12-05 16:06 ` [PATCH 2/3] hw/audio: Remove the "use_broken_id" hack from the AC97 device Thomas Huth
2019-12-06 5:52 ` Philippe Mathieu-Daudé
2019-12-05 16:06 ` [PATCH 3/3] hw/pci: Remove the "command_serr_enable" property Thomas Huth
2019-12-06 10:21 ` Paolo Bonzini [this message]
2019-12-06 6:49 ` [PATCH 0/3] Remove deprecated pc-0.x machine types and related hacks Markus Armbruster
2019-12-06 8:29 ` Thomas Huth
2019-12-06 10:57 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d71b68b-ac66-46ed-b9d6-e54d40b7cb88@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).