From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40E77CAC5B0 for ; Fri, 3 Oct 2025 14:41:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4gwO-0003uH-8M; Fri, 03 Oct 2025 10:39:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4gwJ-0003tj-JY for qemu-devel@nongnu.org; Fri, 03 Oct 2025 10:39:19 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v4gw7-00063B-Uj for qemu-devel@nongnu.org; Fri, 03 Oct 2025 10:39:19 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-781010ff051so1803195b3a.0 for ; Fri, 03 Oct 2025 07:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759502337; x=1760107137; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=qj2M7pQmFYVDX7KwBJSCJqwEHIagQtqZZ1FYUBfhobg=; b=MF+BvMwRgYLRkSsvCRBYi2ORaGY0ckVkdINbRDh6eJ+EHcs2E3E85wqmo2UFupo5XW 5j6/YjLECcMvfarkXKBGwRyeQ9rAW6QecCUSzeAr5lKnKs2x5fi4DDSp/NHp1DHeAhLX o/iGvIeMkHoz3IxhqXsII4VJUBjbAgQsAeSXqSM9IfTr01MBQBuW/m9jPO2I9wjL0TSf V2UG5bys75rwtTlExifThp1UGYPGLKDV7vNm50cNRFRdZOvcfY9NCbpcimcWSPZnrF9J M569LoAuI2bTTPhefIFOIWmGjXumI0SVubqxv9Uw5T4FIlnwSHOK6exLDW2lo5yHOrVX Sklg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759502337; x=1760107137; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qj2M7pQmFYVDX7KwBJSCJqwEHIagQtqZZ1FYUBfhobg=; b=kUiEj8jjm/VT8/68NHCf94GjLL4/tPRytD3ZHnu5xablQtGY6ksUVwPNm0eOsUqWI8 kpTw9xzSAP+QHMmsa1CeG9I9i2NV1k7fqbsqSR9eaXcSpecRRrJ8HpaJrtp688FRYBdX ypM+tHC48MCntbmD3pv+mIHWAkfdZCF9OO9NhAipdGkE+dvz1avlQc7BxxEsKD+x7eJU BXEQDEcIS0rcyH77bXw2g6itVMjB2xEVsij1xfUD5AdBkAE7+JRAs7PxAHTVBluGJVm4 Kk6XgbVShC069Zr4Fk7GUplcBj+n4OavCvsF3/V/mPXrpr9GlEU5ge56I65ACJq4D8+s 2wlw== X-Forwarded-Encrypted: i=1; AJvYcCUcSYnjKgASaotiFEuP7pP+udqzHsVNvgiw7nLSKZvCYeF6lvo9EpCRNBt5jxFy+AgU/gNKyAMtu32H@nongnu.org X-Gm-Message-State: AOJu0YxccHdhUd4rQQGnbJSD6aFQlIqLdZhHMU211K3ozLKzp666Wviq /3aawF1g8e3/T4hlRcVzJ6eQhfU23XwAw/FlmIP6jg+R9EAaaSvFkOT2Ms78ZdNVTTY= X-Gm-Gg: ASbGnct62Yu0Pw5PNh67R9/YN2k3pcWngbSyQMBRGRHFthuV0tre6ZvrzRY4Bgm4aEU IPajFuzqZuSl8joy1yfLM54/PNNouyJTxSVv/3XLOnU4ObsJZ3VOEMcTuufSF11fTvwYcv/0vE3 /tjgISmLiWJDe3VmxPQDivMsHO7bhGgtp1sUgk+JcNbF9pNzI3VZusJ/CRumzkJ5bydqMeZGEe3 67lup11bONyGSySumatTIeGwy8r21JDQtjx6whsKhY8BjzV8UMz5ft3rc9p4nmAdt46hBGHYWGe dXqIR9OeA2Plub2V5/vHeGpqPhozEVWtnZj4tkbNV9DGF4S2ZG67BIkzMHer9CQK0dZkpV07k7M NVJSNMbJBYz7R4f/PRXAXuTbCeSywoTeK90kfuL0ADafIojeDm8f3TK2sFPnVFAIUYcAzLUomww == X-Google-Smtp-Source: AGHT+IGYxViI5t9jT9iDd0v2q3AUUuJyg7Gn1R4FA46ru3DdWMRJz74dQgLCK27vJFuo5vRHUMIlCQ== X-Received: by 2002:a05:6a00:1884:b0:781:275a:29e9 with SMTP id d2e1a72fcca58-78c98cabc07mr3964818b3a.16.1759502337380; Fri, 03 Oct 2025 07:38:57 -0700 (PDT) Received: from [192.168.0.102] ([186.215.59.111]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-78b02053dfesm5172081b3a.51.2025.10.03.07.38.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Oct 2025 07:38:57 -0700 (PDT) Message-ID: <8d89f02e-9e5b-4cdd-9a54-d55bea8967bc@linaro.org> Date: Fri, 3 Oct 2025 11:38:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/9] tests/functional: Adapt reverse_debugging to run w/o Avocado From: Gustavo Romero To: Thomas Huth , qemu-devel@nongnu.org, alex.bennee@linaro.org, berrange@redhat.com Cc: qemu-arm@nongnu.org References: <20251002020432.54443-1-gustavo.romero@linaro.org> <8fb3351e-f1a1-4a1e-9650-33f0d4ee6d44@redhat.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=gustavo.romero@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Thomas, On 10/3/25 10:30, Gustavo Romero wrote: > Hi Thomas, > > On 10/2/25 14:52, Thomas Huth wrote: >> On 02/10/2025 18.53, Thomas Huth wrote: >>> On 02/10/2025 04.04, Gustavo Romero wrote: >>>> The goal of this series is to remove Avocado as a dependency for running >>>> the reverse_debugging functional test. >>>> >>>> After several rounds of discussions about v1 and v2, and experiments >>>> done by Daniel and Thomas (thanks for all the experiments and comments >>>> so far), I've taken a new approach and moved away from using a runner >>>> for GDB. The changes, I believe, are much simpler now. >>> >>>   Hi Gustavo, >>> >>> unfortunately, this still seems to be broken on Fedora. After applying your series, I get: >>> >>> stderr: >>> Traceback (most recent call last): >>>    File "/home/thuth/devel/qemu/tests/functional/reverse_debugging.py", line 100, in reverse_debugging >>>      self.reverse_debugging_run(vm, port, gdb_arch, last_icount) >>>      ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>    File "/usr/lib64/python3.13/unittest/case.py", line 156, in skip_wrapper >>>      raise SkipTest(reason) >>> unittest.case.SkipTest: Missing env var(s): QEMU_TEST_GDB >> >> Looks like it's required to explicitly use the --gdb=... parameter of configure to make it work, and it does not work without that paramter? Could you please have a look whether it works without --gdb with the auto-detected gdb for you? > > Yes, it works without passing --gdb on Ubuntu. I'm checking it on Fedora. > > But at least have you got the test skipped properly (displayed on Meson as skipped) since QEMU_TEST_GDB is missing? hmm actually, no it's not skipped correctly. The @skipIfMissingEnv() annotation is in the wrong method. I've just sent a v6 with: diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py index f06996089a..2a2e51b912 100644 --- a/tests/functional/reverse_debugging.py +++ b/tests/functional/reverse_debugging.py @@ -63,6 +63,7 @@ def vm_get_icount(vm): return vm.qmp('query-replay')['return']['icount'] @skipIfMissingImports("pygdbmi") # Required by GDB class + @skipIfMissingEnv("QEMU_TEST_GDB") def reverse_debugging(self, gdb_arch, shift=7, args=None): from qemu_test import GDB @@ -108,7 +109,6 @@ def reverse_debugging(self, gdb_arch, shift=7, args=None): # skipTest(), etc. raise - @skipIfMissingEnv("QEMU_TEST_GDB") def reverse_debugging_run(self, vm, port, gdb_arch, last_icount): logger = logging.getLogger('replay') Now, I have not idea why GDB is not detected in Fedora. I'm setting up a Fedora env. to try it. Are you sure GDB is installed in your test env? Do mind checking if: gromero@gromero0:/mnt/git/qemu_$ gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb") gromero@gromero0:/mnt/git/qemu_$ echo $gdb_bin /usr/bin/gdb works in your env and if QEMU_TEST_GDB is in: $ ./pyvenv/bin/meson test --verbose --no-rebuild -t 1 --setup thorough --suite func-thorough func-aarch64-reverse_debug output? Cheers, Gustavo