From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A26F4CAC5A5 for ; Wed, 24 Sep 2025 10:19:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1MZs-0005SM-1T; Wed, 24 Sep 2025 06:18:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1MZo-0005RR-7v for qemu-devel@nongnu.org; Wed, 24 Sep 2025 06:18:20 -0400 Received: from 10.mo552.mail-out.ovh.net ([87.98.187.244]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1MZl-0003cl-7z for qemu-devel@nongnu.org; Wed, 24 Sep 2025 06:18:19 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.110.58.89]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id 4cWt8j10s2z5xnc; Wed, 24 Sep 2025 10:18:13 +0000 (UTC) Received: from kaod.org (37.59.142.110) by DAG8EX2.mxp5.local (172.16.2.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.59; Wed, 24 Sep 2025 12:18:12 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-110S004dd71ae72-f1f5-4569-865c-b52d18d36ee4, FFBB6E977D22EB3F6A0A3CEA11E4CFA931BEF3A6) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <8dadee14-1c58-4122-8bd3-db4aca9fd951@kaod.org> Date: Wed, 24 Sep 2025 12:18:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] hw/arm/aspeed_ast27x0-fc: Add VBOOTROM support To: Jamin Lin , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: References: <20250924055602.294857-1-jamin_lin@aspeedtech.com> <20250924055602.294857-8-jamin_lin@aspeedtech.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@kaod.org; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/ jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+ S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6 hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/ t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475 KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8 o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0 IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250924055602.294857-8-jamin_lin@aspeedtech.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.110] X-ClientProxiedBy: DAG3EX1.mxp5.local (172.16.2.21) To DAG8EX2.mxp5.local (172.16.2.72) X-Ovh-Tracer-GUID: 74d08e3b-1933-4ae0-b855-0035033f806b X-Ovh-Tracer-Id: 14223775000604478256 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: dmFkZTFQeBHXiaKPjkjjKqyUZ2N6jw1alt3VReKi/zi/9g5o7hv/xzZFsbdfzYPEUdpA1dJVWnNcjV711twQjtGiN31q6MUJ8q4Rw1G3YWu9l8amGjZqjSQVKOuf5VGrkBlVQWvmNhNzaiEQ6yRGP/WW8SwtZLtGRhD005SpzoD3xg0ByTrD1C9Ba6Pj+rmRXGY4Gro15A19a8qILJJGJ2q/B8jxoPlbETnznQiptFadgaQoztW8fWD6sbnG48a4BH1eh6zEswJSm1Lo+y6WxYjYLzZJL1exi4aq2/zxYNkewGGps1w+y0rJ2BXxPxSHwNQrpXuC6U77XP06sR24d+LhuWiDUa3EOAbx7G8LEKyDRPeP9bR0G2kBeMZD+6gCGb0+yt6mWuSBoIThpcNR9Zm8g9mlbDOwh98tDVOzwJSSm2icDTWwA9XUvlx/FeCP+KugZqCrGSuugU1tGcVnu0q9p3CKEFjIaOuFG7eI/9Xbd5eVk9VV4h5ctouJ4GjosHMCAGdXbO+W7FuQAZ+aThBSorcG30PtIKHmzGKG5FVf02JnhOgFrESDv0mvcpajcAK3+FfHc3OZf8EOM4RmQyMkb+55x7HEo3JMdx7GRLHtY8qlSE4rr4vjPEdkkl9Y0H2j4v55Qo/QV9vqSeZ0Zuy65hBegqLxcjGCgkDeeKojnAdOog DKIM-Signature: a=rsa-sha256; bh=T7hPPcjccDxB4NSjPMZ1oymxcqo5xlIX2gxuuh7sg6E=; c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1; t=1758709093; v=1; b=sXxJGPWsRZ/bzw3lIgmdF+i2oEdMSBD1sij6VeZqFSsooEBhbZNXkHy/h7M2OKaLOVDwXg1r NczgfykGZ0hZfAXke+mBBzb/erQwUx2vewXsugDnSuM6RvoHN9ujUqI+V4m7Jg9kqRtcNqlPP8G BUKYCv92FdSIRQsWX38touNKNBk361PXQwajulZNUUQfSW5sfLP2UuYERd5DQtOENp9sTSWp05g /roHljZAkglrknfsD21xR/i5OK86Djt86hCsaPHF2z+gU3lf1o3zaQSVe1zhE7y/6MDBkkRIf0H Idys9WcDHZ8CHVhsYuT4z7hx5IdlSLkUCb7Tufr4oWeJQ== Received-SPF: pass client-ip=87.98.187.244; envelope-from=clg@kaod.org; helo=10.mo552.mail-out.ovh.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/24/25 07:56, Jamin Lin wrote: > Introduces support for loading a vbootrom image into the dedicated vbootrom > memory region in the AST2700 Full Core machine. > > Signed-off-by: Jamin Lin > --- > hw/arm/aspeed_ast27x0-fc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c > index 2e6036b192..b2d963e1fe 100644 > --- a/hw/arm/aspeed_ast27x0-fc.c > +++ b/hw/arm/aspeed_ast27x0-fc.c > @@ -62,6 +62,7 @@ static void ast2700fc_ca35_init(MachineState *machine) > Ast2700FCState *s = AST2700A1FC(machine); > AspeedSoCState *soc; > AspeedSoCClass *sc; > + const char *bios_name = NULL; > BlockBackend *fmc0 = NULL; > DeviceState *dev = NULL; > Error **errp = NULL; > @@ -133,6 +134,10 @@ static void ast2700fc_ca35_init(MachineState *machine) > } > } > > + /* VBOOTROM */ > + bios_name = machine->firmware ?: VBOOTROM_FILE_NAME; > + aspeed_load_vbootrom(soc, bios_name, errp); > + > arm_load_kernel(ARM_CPU(first_cpu), machine, &ast2700fc_board_info); > } > Reviewed-by: Cédric Le Goater Thanks, C.