From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPQ0G-0001gE-Pc for qemu-devel@nongnu.org; Wed, 21 Nov 2018 05:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPQ0D-0005PG-Jj for qemu-devel@nongnu.org; Wed, 21 Nov 2018 05:45:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52236) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPQ0D-0005Ob-Ba for qemu-devel@nongnu.org; Wed, 21 Nov 2018 05:45:01 -0500 References: <20181120092542.13102-1-david@redhat.com> <20181120092542.13102-3-david@redhat.com> <7d8d4e4f-bb70-5047-4e37-ed3672c89e02@redhat.com> <87va4r7aou.fsf@dusky.pond.sub.org> <64d0f403-2dd3-2841-b346-7634f37cf5b8@redhat.com> From: David Hildenbrand Message-ID: <8dc6889b-eed7-34f2-8bef-c03b11dc435a@redhat.com> Date: Wed, 21 Nov 2018 11:44:57 +0100 MIME-Version: 1.0 In-Reply-To: <64d0f403-2dd3-2841-b346-7634f37cf5b8@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/9] cutils: Fix qemu_strtosz() & friends to reject non-finite sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Markus Armbruster Cc: qemu-devel@nongnu.org, Paolo Bonzini , Michael Roth On 20.11.18 21:41, Eric Blake wrote: > On 11/20/18 2:31 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 11/20/18 3:25 AM, David Hildenbrand wrote: >>>> qemu_strtosz() & friends reject NaNs, but happily accept inifities. >>> >>> s/inifities/infinities/ >>> >>>> They shouldn't. Fix that. >>>> >>>> The fix makes use of qemu_strtod_finite(). To avoid ugly casts, >>>> change the @end parameter of qemu_strtosz() & friends from char ** >>>> to const char **. >>>> >>>> Also, add two test cases, testing that "inf" and "NaN" are properly >>>> rejected. >>>> >>>> Signed-off-by: David Hildenbrand >>>> --- >>>> include/qemu/cutils.h | 6 +++--- >>>> monitor.c | 2 +- >>>> tests/test-cutils.c | 24 +++++++++++++++++------- >>>> util/cutils.c | 16 +++++++--------- >>>> 4 files changed, 28 insertions(+), 20 deletions(-) >>>> >>> >>>> +++ b/util/cutils.c >>>> @@ -206,20 +206,18 @@ static int64_t suffix_mul(char suffix, int64_t unit) >>>> * in *end, if not NULL. Return -ERANGE on overflow, Return -EINVAL on >>> >>> Pre-existing, but since you're touching this area: the second 'Return' >>> is unusual capitalization for being mid-sentence. You could even >>> s/Return/of/ >> >> "of"? > > "or" (ouch - wrong time for my fingers to be slipping on the keyboard) Shouldn't that be "and" and s/Return/Returns/ "Returns -ERANGE on overflow and -EINVAL on other errors". I can include that fixup (whetever version you guys prefer) > > >>> It's some hairy code to think about, but I can't find anything wrong >>> with it. Typo fixes are minor, so >>> >>> Reviewed-by: Eric Blake >> >> Thanks for your analysis, Eric. >> >> With the typo fixes: > > Including the fix of my attempt at a typo fix :) > >> Reviewed-by: Markus Armbruster Thanks! -- Thanks, David / dhildenb