From: Miles Glenn <milesg@linux.vnet.ibm.com>
To: Andrew Jeffery <andrew@codeconstruct.com.au>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Joel Stanley" <joel@jms.id.au>,
philmd@linaro.org
Subject: Re: [PATCH v2 1/3] misc/pca9552: Fix inverted input status
Date: Tue, 24 Oct 2023 11:49:55 -0500 [thread overview]
Message-ID: <8dca5989e1db6f433c63183a3922f5ed90582ab1.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <3bf8cd017b5d1386e1ed15392c74ed647b993011.camel@codeconstruct.com.au>
On Tue, 2023-10-24 at 10:15 +1030, Andrew Jeffery wrote:
> On Fri, 2023-10-20 at 13:23 -0500, Glenn Miles wrote:
> > The pca9552 INPUT0 and INPUT1 registers are supposed to
> > hold the logical values of the LED pins. A logical 0
> > should be seen in the INPUT0/1 registers for a pin when
> > its corresponding LSn bits are set to 0, which is also
> > the state needed for turning on an LED in a typical
> > usage scenario. Existing code was doing the opposite
> > and setting INPUT0/1 bit to a 1 when the LSn bit was
> > set to 0, so this commit fixes that.
> >
> > Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
>
> I sent a Reviewed-by tag for v1, don't forget to collect those on
> your
> patches before sending out a new set. Something for next time :)
>
> Anyway,
>
> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
>
Yeah, of course I realized that I forgot that after sending it! :-)
Glenn
next prev parent reply other threads:[~2023-10-24 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 18:23 [PATCH v2 0/3] misc/pca9552: Changes to support powernv10 Glenn Miles
2023-10-20 18:23 ` [PATCH v2 1/3] misc/pca9552: Fix inverted input status Glenn Miles
2023-10-23 23:45 ` Andrew Jeffery
2023-10-24 16:49 ` Miles Glenn [this message]
2023-10-20 18:23 ` [PATCH v2 2/3] misc/pca9552: Let external devices set pca9552 inputs Glenn Miles
2023-10-20 18:23 ` [PATCH v2 3/3] misc/pca9552: Only update output GPIOs if state changed Glenn Miles
2023-10-23 23:43 ` Andrew Jeffery
2023-10-24 16:48 ` Miles Glenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dca5989e1db6f433c63183a3922f5ed90582ab1.camel@linux.vnet.ibm.com \
--to=milesg@linux.vnet.ibm.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).