From: Shivaprasad G Bhat <sbhat@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
philmd@linaro.org, richard.henderson@linaro.org,
danielhb413@gmail.com, lucas.araujo@eldorado.org.br,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, groug@kaod.org
Cc: john_platts@hotmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] tests: tcg: ppc64: Add tests for Vector Extract Mask Instructions
Date: Thu, 4 May 2023 10:47:28 +0530 [thread overview]
Message-ID: <8ddf6bcf-c499-9173-a3a0-7aa86dd9d42a@linux.ibm.com> (raw)
In-Reply-To: <0435d42f-e48a-3c51-108a-df284fc496ab@kaod.org>
On 5/2/23 12:35, Cédric Le Goater wrote:
> On 4/13/23 21:01, Shivaprasad G Bhat wrote:
>> Add test for vextractbm, vextractwm, vextractdm and vextractqm
>> instructions. Test works for both qemu-ppc64 and qemu-ppc64le.
>>
>> Based on the test case written by John Platts posted at [1]
>>
>> References:
>> [1]: https://gitlab.com/qemu-project/qemu/-/issues/1536
>
> Gitlab issues should be referenced as :
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1536
>
> However, this patch adds a test, not a fix. So it is the previous patch
> which should be annotated as resolving the issue.
>
> Also, I think the code should be using HOST_BIG_ENDIAN instead of
> __ORDER_BIG_ENDIAN__
>
Thanks for the comments Cédric.
Fixing these in v2.
Thanks,
Shivaprasad
next prev parent reply other threads:[~2023-05-04 5:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 19:00 [PATCH 0/2] tcg: ppc64: Fix mask generation for vextractdm Shivaprasad G Bhat
2023-04-13 19:01 ` [PATCH 1/2] " Shivaprasad G Bhat
2023-05-02 9:03 ` Alex Bennée
2023-05-02 10:50 ` Richard Henderson
2023-05-02 14:02 ` Lucas Mateus Martins Araujo e Castro
2023-04-13 19:01 ` [PATCH 2/2] tests: tcg: ppc64: Add tests for Vector Extract Mask Instructions Shivaprasad G Bhat
2023-05-02 7:05 ` Cédric Le Goater
2023-05-04 5:17 ` Shivaprasad G Bhat [this message]
2023-05-02 15:05 ` Lucas Mateus Martins Araujo e Castro
2023-05-03 14:31 ` [PATCH 0/2] tcg: ppc64: Fix mask generation for vextractdm Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ddf6bcf-c499-9173-a3a0-7aa86dd9d42a@linux.ibm.com \
--to=sbhat@linux.ibm.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=john_platts@hotmail.com \
--cc=lucas.araujo@eldorado.org.br \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).