From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmyWE-0001Mt-MG for qemu-devel@nongnu.org; Tue, 07 Aug 2018 05:43:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmyWA-000077-Io for qemu-devel@nongnu.org; Tue, 07 Aug 2018 05:43:10 -0400 References: <20180805182832.3012-1-pavel.zbitskiy@gmail.com> <20180805182832.3012-6-pavel.zbitskiy@gmail.com> From: Thomas Huth Message-ID: <8de24c1a-a51a-35a4-19a8-cec480848bea@redhat.com> Date: Tue, 7 Aug 2018 11:42:54 +0200 MIME-Version: 1.0 In-Reply-To: <20180805182832.3012-6-pavel.zbitskiy@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH 5/6] target/s390x: fix PACK reading 1 byte less and writing 1 byte more List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Zbitskiy , qemu-devel@nongnu.org Cc: David Hildenbrand , qemu-trivial@nongnu.org, Cornelia Huck , Alexander Graf , "open list:S390" , Richard Henderson On 08/05/2018 08:28 PM, Pavel Zbitskiy wrote: > PACK fails on the test from the Principles of Operation: F1F2F3F4 > becomes 0000234C instead of 0001234C due to an off-by-one error. > Furthermore, it overwrites one extra byte to the left of F1. Hi Pavel, thanks for fixing these bugs in the s390x instructions! If you've got some more spare minutes, could you maybe also add regression tests for these (user space) instruction to the tests/tcg/s390x folder? ... we really need some tests there ... Thomas