* [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector
@ 2023-07-31 9:10 Akihiko Odaki
2023-07-31 9:10 ` [PATCH v2 1/2] tests/migration: Add -fno-stack-protector Akihiko Odaki
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Akihiko Odaki @ 2023-07-31 9:10 UTC (permalink / raw)
Cc: Christian Borntraeger, Thomas Huth, Juan Quintela, Peter Xu,
Leonardo Bras, Peter Maydell, Richard Henderson,
Edgar E . Iglesias, Brian Cain, Paolo Bonzini, Eduardo Habkost,
Song Gao, Xiaojuan Yang, Philippe Mathieu-Daudé,
Aurelien Jarno, Jiaxun Yang, Aleksandar Rikalo, Chris Wulff,
Marek Vasut, David Hildenbrand, Ilya Leoshkevich, qemu-devel,
qemu-s390x, qemu-arm, Akihiko Odaki
A build of GCC 13.2 will have stack protector enabled by default if it was
configured with --enable-default-ssp option. For such a compiler, it is
necessary to explicitly disable stack protector when linking without
standard libraries.
This is a tree-wide change to add -fno-stack-protector where -nostdlib is
present.
V1 -> V2:
Dropped changes for pc-bios as they already had the option. (Thomas Huth)
Make the change for softmmu tests in a central place. (Thomas Huth)
Akihiko Odaki (2):
tests/migration: Add -fno-stack-protector
tests/tcg: Add -fno-stack-protector
tests/tcg/mips/hello-mips.c | 4 ++--
tests/migration/s390x/Makefile | 4 ++--
tests/tcg/Makefile.target | 2 +-
tests/tcg/aarch64/Makefile.target | 2 +-
tests/tcg/arm/Makefile.target | 2 +-
tests/tcg/cris/Makefile.target | 2 +-
tests/tcg/hexagon/Makefile.target | 2 +-
tests/tcg/i386/Makefile.target | 2 +-
tests/tcg/minilib/Makefile.target | 2 +-
tests/tcg/mips/Makefile.target | 2 +-
10 files changed, 12 insertions(+), 12 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] tests/migration: Add -fno-stack-protector
2023-07-31 9:10 [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector Akihiko Odaki
@ 2023-07-31 9:10 ` Akihiko Odaki
2023-07-31 9:10 ` [PATCH v2 2/2] tests/tcg: " Akihiko Odaki
2023-11-01 9:58 ` [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector Michael Tokarev
2 siblings, 0 replies; 6+ messages in thread
From: Akihiko Odaki @ 2023-07-31 9:10 UTC (permalink / raw)
Cc: Christian Borntraeger, Thomas Huth, Juan Quintela, Peter Xu,
Leonardo Bras, Peter Maydell, Richard Henderson,
Edgar E . Iglesias, Brian Cain, Paolo Bonzini, Eduardo Habkost,
Song Gao, Xiaojuan Yang, Philippe Mathieu-Daudé,
Aurelien Jarno, Jiaxun Yang, Aleksandar Rikalo, Chris Wulff,
Marek Vasut, David Hildenbrand, Ilya Leoshkevich, qemu-devel,
qemu-s390x, qemu-arm, Akihiko Odaki
A build of GCC 13.2 will have stack protector enabled by default if it
was configured with --enable-default-ssp option. For such a compiler,
it is necessary to explicitly disable stack protector when linking
without standard libraries.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
tests/migration/s390x/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/migration/s390x/Makefile b/tests/migration/s390x/Makefile
index 6393c3e5b9..6671de2efc 100644
--- a/tests/migration/s390x/Makefile
+++ b/tests/migration/s390x/Makefile
@@ -6,8 +6,8 @@ all: a-b-bios.h
fwdir=../../../pc-bios/s390-ccw
CFLAGS+=-ffreestanding -fno-delete-null-pointer-checks -fPIE -Os \
- -msoft-float -march=z900 -fno-asynchronous-unwind-tables -Wl,-pie \
- -Wl,--build-id=none -nostdlib
+ -msoft-float -march=z900 -fno-asynchronous-unwind-tables \
+ -fno-stack-protector -Wl,-pie -Wl,--build-id=none -nostdlib
a-b-bios.h: s390x.elf
echo "$$__note" > header.tmp
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] tests/tcg: Add -fno-stack-protector
2023-07-31 9:10 [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector Akihiko Odaki
2023-07-31 9:10 ` [PATCH v2 1/2] tests/migration: Add -fno-stack-protector Akihiko Odaki
@ 2023-07-31 9:10 ` Akihiko Odaki
2023-09-22 16:45 ` Thomas Huth
2023-11-01 9:58 ` [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector Michael Tokarev
2 siblings, 1 reply; 6+ messages in thread
From: Akihiko Odaki @ 2023-07-31 9:10 UTC (permalink / raw)
Cc: Christian Borntraeger, Thomas Huth, Juan Quintela, Peter Xu,
Leonardo Bras, Peter Maydell, Richard Henderson,
Edgar E . Iglesias, Brian Cain, Paolo Bonzini, Eduardo Habkost,
Song Gao, Xiaojuan Yang, Philippe Mathieu-Daudé,
Aurelien Jarno, Jiaxun Yang, Aleksandar Rikalo, Chris Wulff,
Marek Vasut, David Hildenbrand, Ilya Leoshkevich, qemu-devel,
qemu-s390x, qemu-arm, Akihiko Odaki
A build of GCC 13.2 will have stack protector enabled by default if it
was configured with --enable-default-ssp option. For such a compiler,
it is necessary to explicitly disable stack protector when linking
without standard libraries.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
tests/tcg/mips/hello-mips.c | 4 ++--
tests/tcg/Makefile.target | 2 +-
tests/tcg/aarch64/Makefile.target | 2 +-
tests/tcg/arm/Makefile.target | 2 +-
tests/tcg/cris/Makefile.target | 2 +-
tests/tcg/hexagon/Makefile.target | 2 +-
tests/tcg/i386/Makefile.target | 2 +-
tests/tcg/minilib/Makefile.target | 2 +-
tests/tcg/mips/Makefile.target | 2 +-
9 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/tcg/mips/hello-mips.c b/tests/tcg/mips/hello-mips.c
index 4e1cf501af..0ba5f1bf23 100644
--- a/tests/tcg/mips/hello-mips.c
+++ b/tests/tcg/mips/hello-mips.c
@@ -5,8 +5,8 @@
* http://www.linux-mips.org/wiki/MIPSABIHistory
* http://www.linux.com/howtos/Assembly-HOWTO/mips.shtml
*
-* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -mabi=32 \
-* -O2 -static -o hello-mips hello-mips.c
+* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -fno-stack-protector \
+ -mabi=32 -O2 -static -o hello-mips hello-mips.c
*
*/
#define __NR_SYSCALL_BASE 4000
diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
index 3d7837d3b8..c43020d990 100644
--- a/tests/tcg/Makefile.target
+++ b/tests/tcg/Makefile.target
@@ -123,7 +123,7 @@ else
# For softmmu targets we include a different Makefile fragment as the
# build options for bare programs are usually pretty different. They
# are expected to provide their own build recipes.
-EXTRA_CFLAGS += -ffreestanding
+EXTRA_CFLAGS += -ffreestanding -fno-stack-protector
-include $(SRC_PATH)/tests/tcg/minilib/Makefile.target
-include $(SRC_PATH)/tests/tcg/multiarch/system/Makefile.softmmu-target
-include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.softmmu-target
diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
index 617f821613..55f8609897 100644
--- a/tests/tcg/aarch64/Makefile.target
+++ b/tests/tcg/aarch64/Makefile.target
@@ -49,7 +49,7 @@ endif
# bti-1 tests the elf notes, so we require special compiler support.
ifneq ($(CROSS_CC_HAS_ARMV8_BTI),)
AARCH64_TESTS += bti-1 bti-3
-bti-1 bti-3: CFLAGS += -mbranch-protection=standard
+bti-1 bti-3: CFLAGS += -fno-stack-protector -mbranch-protection=standard
bti-1 bti-3: LDFLAGS += -nostdlib
endif
# bti-2 tests PROT_BTI, so no special compiler support required.
diff --git a/tests/tcg/arm/Makefile.target b/tests/tcg/arm/Makefile.target
index 0038cef02c..3473f4619e 100644
--- a/tests/tcg/arm/Makefile.target
+++ b/tests/tcg/arm/Makefile.target
@@ -12,7 +12,7 @@ float_madds: CFLAGS+=-mfpu=neon-vfpv4
# Basic Hello World
ARM_TESTS = hello-arm
-hello-arm: CFLAGS+=-marm -ffreestanding
+hello-arm: CFLAGS+=-marm -ffreestanding -fno-stack-protector
hello-arm: LDFLAGS+=-nostdlib
# IWMXT floating point extensions
diff --git a/tests/tcg/cris/Makefile.target b/tests/tcg/cris/Makefile.target
index 43587d2769..713e2a5b6c 100644
--- a/tests/tcg/cris/Makefile.target
+++ b/tests/tcg/cris/Makefile.target
@@ -30,7 +30,7 @@ AS = $(CC) -x assembler-with-cpp
LD = $(CC)
# we rely on GCC inline:ing the stuff we tell it to in many places here.
-CFLAGS = -Winline -Wall -g -O2 -static
+CFLAGS = -Winline -Wall -g -O2 -static -fno-stack-protector
NOSTDFLAGS = -nostartfiles -nostdlib
ASFLAGS += -mcpu=v10 -g -Wa,-I,$(SRC_PATH)/tests/tcg/cris/bare
CRT_FILES = crt.o sys.o
diff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target
index 87ed2c90b9..f839b2c0d5 100644
--- a/tests/tcg/hexagon/Makefile.target
+++ b/tests/tcg/hexagon/Makefile.target
@@ -19,7 +19,7 @@
EXTRA_RUNS =
CFLAGS += -Wno-incompatible-pointer-types -Wno-undefined-internal
-CFLAGS += -fno-unroll-loops
+CFLAGS += -fno-unroll-loops -fno-stack-protector
HEX_SRC=$(SRC_PATH)/tests/tcg/hexagon
VPATH += $(HEX_SRC)
diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
index fdf757c6ce..3dec7c6c42 100644
--- a/tests/tcg/i386/Makefile.target
+++ b/tests/tcg/i386/Makefile.target
@@ -35,7 +35,7 @@ run-test-aes: QEMU_OPTS += -cpu max
#
# hello-i386 is a barebones app
#
-hello-i386: CFLAGS+=-ffreestanding
+hello-i386: CFLAGS+=-ffreestanding -fno-stack-protector
hello-i386: LDFLAGS+=-nostdlib
# test-386 includes a couple of additional objects that need to be
diff --git a/tests/tcg/minilib/Makefile.target b/tests/tcg/minilib/Makefile.target
index c821d2806a..af0bf54be9 100644
--- a/tests/tcg/minilib/Makefile.target
+++ b/tests/tcg/minilib/Makefile.target
@@ -12,7 +12,7 @@ SYSTEM_MINILIB_SRC=$(SRC_PATH)/tests/tcg/minilib
MINILIB_SRCS=$(wildcard $(SYSTEM_MINILIB_SRC)/*.c)
MINILIB_OBJS=$(patsubst $(SYSTEM_MINILIB_SRC)/%.c, %.o, $(MINILIB_SRCS))
-MINILIB_CFLAGS+=-nostdlib -ggdb -O0
+MINILIB_CFLAGS+=-nostdlib -fno-stack-protector -ggdb -O0
MINILIB_INC=-isystem $(SYSTEM_MINILIB_SRC)
.PRECIOUS: $(MINILIB_OBJS)
diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target
index 1a994d5525..5d17c1706e 100644
--- a/tests/tcg/mips/Makefile.target
+++ b/tests/tcg/mips/Makefile.target
@@ -14,6 +14,6 @@ MIPS_TESTS=hello-mips
TESTS += $(MIPS_TESTS)
-hello-mips: CFLAGS+=-mno-abicalls -fno-PIC -mabi=32
+hello-mips: CFLAGS+=-mno-abicalls -fno-PIC -fno-stack-protector -mabi=32
hello-mips: LDFLAGS+=-nostdlib
endif
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] tests/tcg: Add -fno-stack-protector
2023-07-31 9:10 ` [PATCH v2 2/2] tests/tcg: " Akihiko Odaki
@ 2023-09-22 16:45 ` Thomas Huth
2023-10-19 12:40 ` Alex Bennée
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2023-09-22 16:45 UTC (permalink / raw)
To: Akihiko Odaki, Alex Bennée
Cc: Christian Borntraeger, Juan Quintela, Peter Xu, Leonardo Bras,
Peter Maydell, Richard Henderson, Edgar E . Iglesias, Brian Cain,
Paolo Bonzini, Eduardo Habkost, Song Gao, Xiaojuan Yang,
Philippe Mathieu-Daudé, Aurelien Jarno, Jiaxun Yang,
Aleksandar Rikalo, Chris Wulff, Marek Vasut, David Hildenbrand,
Ilya Leoshkevich, qemu-devel, qemu-s390x, qemu-arm
On 31/07/2023 11.10, Akihiko Odaki wrote:
> A build of GCC 13.2 will have stack protector enabled by default if it
> was configured with --enable-default-ssp option. For such a compiler,
> it is necessary to explicitly disable stack protector when linking
> without standard libraries.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> tests/tcg/mips/hello-mips.c | 4 ++--
> tests/tcg/Makefile.target | 2 +-
> tests/tcg/aarch64/Makefile.target | 2 +-
> tests/tcg/arm/Makefile.target | 2 +-
> tests/tcg/cris/Makefile.target | 2 +-
> tests/tcg/hexagon/Makefile.target | 2 +-
> tests/tcg/i386/Makefile.target | 2 +-
> tests/tcg/minilib/Makefile.target | 2 +-
> tests/tcg/mips/Makefile.target | 2 +-
> 9 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tests/tcg/mips/hello-mips.c b/tests/tcg/mips/hello-mips.c
> index 4e1cf501af..0ba5f1bf23 100644
> --- a/tests/tcg/mips/hello-mips.c
> +++ b/tests/tcg/mips/hello-mips.c
> @@ -5,8 +5,8 @@
> * http://www.linux-mips.org/wiki/MIPSABIHistory
> * http://www.linux.com/howtos/Assembly-HOWTO/mips.shtml
> *
> -* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -mabi=32 \
> -* -O2 -static -o hello-mips hello-mips.c
> +* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -fno-stack-protector \
> + -mabi=32 -O2 -static -o hello-mips hello-mips.c
You've lost the "*" at the beginning of the comment line here.
But apart from that nit, the patch looks sane to me.
Cc:-ing Alex Bennée ... could pick this patch up?
Thomas
> *
> */
> #define __NR_SYSCALL_BASE 4000
> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
> index 3d7837d3b8..c43020d990 100644
> --- a/tests/tcg/Makefile.target
> +++ b/tests/tcg/Makefile.target
> @@ -123,7 +123,7 @@ else
> # For softmmu targets we include a different Makefile fragment as the
> # build options for bare programs are usually pretty different. They
> # are expected to provide their own build recipes.
> -EXTRA_CFLAGS += -ffreestanding
> +EXTRA_CFLAGS += -ffreestanding -fno-stack-protector
> -include $(SRC_PATH)/tests/tcg/minilib/Makefile.target
> -include $(SRC_PATH)/tests/tcg/multiarch/system/Makefile.softmmu-target
> -include $(SRC_PATH)/tests/tcg/$(TARGET_NAME)/Makefile.softmmu-target
> diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
> index 617f821613..55f8609897 100644
> --- a/tests/tcg/aarch64/Makefile.target
> +++ b/tests/tcg/aarch64/Makefile.target
> @@ -49,7 +49,7 @@ endif
> # bti-1 tests the elf notes, so we require special compiler support.
> ifneq ($(CROSS_CC_HAS_ARMV8_BTI),)
> AARCH64_TESTS += bti-1 bti-3
> -bti-1 bti-3: CFLAGS += -mbranch-protection=standard
> +bti-1 bti-3: CFLAGS += -fno-stack-protector -mbranch-protection=standard
> bti-1 bti-3: LDFLAGS += -nostdlib
> endif
> # bti-2 tests PROT_BTI, so no special compiler support required.
> diff --git a/tests/tcg/arm/Makefile.target b/tests/tcg/arm/Makefile.target
> index 0038cef02c..3473f4619e 100644
> --- a/tests/tcg/arm/Makefile.target
> +++ b/tests/tcg/arm/Makefile.target
> @@ -12,7 +12,7 @@ float_madds: CFLAGS+=-mfpu=neon-vfpv4
>
> # Basic Hello World
> ARM_TESTS = hello-arm
> -hello-arm: CFLAGS+=-marm -ffreestanding
> +hello-arm: CFLAGS+=-marm -ffreestanding -fno-stack-protector
> hello-arm: LDFLAGS+=-nostdlib
>
> # IWMXT floating point extensions
> diff --git a/tests/tcg/cris/Makefile.target b/tests/tcg/cris/Makefile.target
> index 43587d2769..713e2a5b6c 100644
> --- a/tests/tcg/cris/Makefile.target
> +++ b/tests/tcg/cris/Makefile.target
> @@ -30,7 +30,7 @@ AS = $(CC) -x assembler-with-cpp
> LD = $(CC)
>
> # we rely on GCC inline:ing the stuff we tell it to in many places here.
> -CFLAGS = -Winline -Wall -g -O2 -static
> +CFLAGS = -Winline -Wall -g -O2 -static -fno-stack-protector
> NOSTDFLAGS = -nostartfiles -nostdlib
> ASFLAGS += -mcpu=v10 -g -Wa,-I,$(SRC_PATH)/tests/tcg/cris/bare
> CRT_FILES = crt.o sys.o
> diff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target
> index 87ed2c90b9..f839b2c0d5 100644
> --- a/tests/tcg/hexagon/Makefile.target
> +++ b/tests/tcg/hexagon/Makefile.target
> @@ -19,7 +19,7 @@
> EXTRA_RUNS =
>
> CFLAGS += -Wno-incompatible-pointer-types -Wno-undefined-internal
> -CFLAGS += -fno-unroll-loops
> +CFLAGS += -fno-unroll-loops -fno-stack-protector
>
> HEX_SRC=$(SRC_PATH)/tests/tcg/hexagon
> VPATH += $(HEX_SRC)
> diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
> index fdf757c6ce..3dec7c6c42 100644
> --- a/tests/tcg/i386/Makefile.target
> +++ b/tests/tcg/i386/Makefile.target
> @@ -35,7 +35,7 @@ run-test-aes: QEMU_OPTS += -cpu max
> #
> # hello-i386 is a barebones app
> #
> -hello-i386: CFLAGS+=-ffreestanding
> +hello-i386: CFLAGS+=-ffreestanding -fno-stack-protector
> hello-i386: LDFLAGS+=-nostdlib
>
> # test-386 includes a couple of additional objects that need to be
> diff --git a/tests/tcg/minilib/Makefile.target b/tests/tcg/minilib/Makefile.target
> index c821d2806a..af0bf54be9 100644
> --- a/tests/tcg/minilib/Makefile.target
> +++ b/tests/tcg/minilib/Makefile.target
> @@ -12,7 +12,7 @@ SYSTEM_MINILIB_SRC=$(SRC_PATH)/tests/tcg/minilib
> MINILIB_SRCS=$(wildcard $(SYSTEM_MINILIB_SRC)/*.c)
> MINILIB_OBJS=$(patsubst $(SYSTEM_MINILIB_SRC)/%.c, %.o, $(MINILIB_SRCS))
>
> -MINILIB_CFLAGS+=-nostdlib -ggdb -O0
> +MINILIB_CFLAGS+=-nostdlib -fno-stack-protector -ggdb -O0
> MINILIB_INC=-isystem $(SYSTEM_MINILIB_SRC)
>
> .PRECIOUS: $(MINILIB_OBJS)
> diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target
> index 1a994d5525..5d17c1706e 100644
> --- a/tests/tcg/mips/Makefile.target
> +++ b/tests/tcg/mips/Makefile.target
> @@ -14,6 +14,6 @@ MIPS_TESTS=hello-mips
>
> TESTS += $(MIPS_TESTS)
>
> -hello-mips: CFLAGS+=-mno-abicalls -fno-PIC -mabi=32
> +hello-mips: CFLAGS+=-mno-abicalls -fno-PIC -fno-stack-protector -mabi=32
> hello-mips: LDFLAGS+=-nostdlib
> endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] tests/tcg: Add -fno-stack-protector
2023-09-22 16:45 ` Thomas Huth
@ 2023-10-19 12:40 ` Alex Bennée
0 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2023-10-19 12:40 UTC (permalink / raw)
To: Thomas Huth
Cc: Akihiko Odaki, Christian Borntraeger, Juan Quintela, Peter Xu,
Leonardo Bras, Peter Maydell, Richard Henderson,
Edgar E . Iglesias, Brian Cain, Paolo Bonzini, Eduardo Habkost,
Song Gao, Xiaojuan Yang, Philippe Mathieu-Daudé,
Aurelien Jarno, Jiaxun Yang, Aleksandar Rikalo, Chris Wulff,
Marek Vasut, David Hildenbrand, Ilya Leoshkevich, qemu-devel,
qemu-s390x, qemu-arm
Thomas Huth <thuth@redhat.com> writes:
> On 31/07/2023 11.10, Akihiko Odaki wrote:
>> A build of GCC 13.2 will have stack protector enabled by default if it
>> was configured with --enable-default-ssp option. For such a compiler,
>> it is necessary to explicitly disable stack protector when linking
>> without standard libraries.
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> ---
>> tests/tcg/mips/hello-mips.c | 4 ++--
>> tests/tcg/Makefile.target | 2 +-
>> tests/tcg/aarch64/Makefile.target | 2 +-
>> tests/tcg/arm/Makefile.target | 2 +-
>> tests/tcg/cris/Makefile.target | 2 +-
>> tests/tcg/hexagon/Makefile.target | 2 +-
>> tests/tcg/i386/Makefile.target | 2 +-
>> tests/tcg/minilib/Makefile.target | 2 +-
>> tests/tcg/mips/Makefile.target | 2 +-
>> 9 files changed, 10 insertions(+), 10 deletions(-)
>> diff --git a/tests/tcg/mips/hello-mips.c
>> b/tests/tcg/mips/hello-mips.c
>> index 4e1cf501af..0ba5f1bf23 100644
>> --- a/tests/tcg/mips/hello-mips.c
>> +++ b/tests/tcg/mips/hello-mips.c
>> @@ -5,8 +5,8 @@
>> * http://www.linux-mips.org/wiki/MIPSABIHistory
>> * http://www.linux.com/howtos/Assembly-HOWTO/mips.shtml
>> *
>> -* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -mabi=32 \
>> -* -O2 -static -o hello-mips hello-mips.c
>> +* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -fno-stack-protector \
>> + -mabi=32 -O2 -static -o hello-mips hello-mips.c
>
> You've lost the "*" at the beginning of the comment line here.
>
> But apart from that nit, the patch looks sane to me.
>
> Cc:-ing Alex Bennée ... could pick this patch up?
Queued to testing/next with tweak to comment, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector
2023-07-31 9:10 [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector Akihiko Odaki
2023-07-31 9:10 ` [PATCH v2 1/2] tests/migration: Add -fno-stack-protector Akihiko Odaki
2023-07-31 9:10 ` [PATCH v2 2/2] tests/tcg: " Akihiko Odaki
@ 2023-11-01 9:58 ` Michael Tokarev
2 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2023-11-01 9:58 UTC (permalink / raw)
To: Akihiko Odaki
Cc: Christian Borntraeger, Thomas Huth, Juan Quintela, Peter Xu,
Leonardo Bras, Peter Maydell, Richard Henderson,
Edgar E . Iglesias, Brian Cain, Paolo Bonzini, Eduardo Habkost,
Song Gao, Xiaojuan Yang, Philippe Mathieu-Daudé,
Aurelien Jarno, Jiaxun Yang, Aleksandar Rikalo, Chris Wulff,
Marek Vasut, David Hildenbrand, Ilya Leoshkevich, qemu-devel,
qemu-s390x, qemu-arm
31.07.2023 12:10, Akihiko Odaki:
> A build of GCC 13.2 will have stack protector enabled by default if it was
> configured with --enable-default-ssp option. For such a compiler, it is
> necessary to explicitly disable stack protector when linking without
> standard libraries.
>
> This is a tree-wide change to add -fno-stack-protector where -nostdlib is
> present.
Should we perhaps pick this up for -stable too?
The changes seems to be harmless for older compiler and lets to test
qemu with more recent compiler.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-01 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-31 9:10 [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector Akihiko Odaki
2023-07-31 9:10 ` [PATCH v2 1/2] tests/migration: Add -fno-stack-protector Akihiko Odaki
2023-07-31 9:10 ` [PATCH v2 2/2] tests/tcg: " Akihiko Odaki
2023-09-22 16:45 ` Thomas Huth
2023-10-19 12:40 ` Alex Bennée
2023-11-01 9:58 ` [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).