From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c17ZP-0000lo-I5 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 04:03:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c17ZL-0006wI-5Y for qemu-devel@nongnu.org; Mon, 31 Oct 2016 04:03:51 -0400 Received: from [59.151.112.132] (port=20606 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c17ZK-0006vm-Fo for qemu-devel@nongnu.org; Mon, 31 Oct 2016 04:03:47 -0400 References: <1477448651-4474-1-git-send-email-jasowang@redhat.com> <1477448651-4474-10-git-send-email-jasowang@redhat.com> <20161030131323.7dc17bcd@bahia> <3baa4c61-f984-ec03-b8c2-0d2f367f3594@cn.fujitsu.com> <24dd6bd4-69fd-1a21-c8bd-207b1f4b1ee7@redhat.com> From: Zhang Chen Message-ID: <8df5227c-0475-59cc-a5fe-a9dbc1a90c4e@cn.fujitsu.com> Date: Mon, 31 Oct 2016 16:05:00 +0800 MIME-Version: 1.0 In-Reply-To: <24dd6bd4-69fd-1a21-c8bd-207b1f4b1ee7@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 9/9] colo-proxy: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , Greg Kurz Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, Stefan Hajnoczi On 10/31/2016 03:40 PM, Jason Wang wrote: > > > On 2016年10月31日 14:37, Zhang Chen wrote: >> >> >> On 10/30/2016 08:13 PM, Greg Kurz wrote: >>> On Wed, 26 Oct 2016 10:24:11 +0800 >>> Jason Wang wrote: >>> >>>> From: Zhang Chen >>>> >>>> Fix memory leak in colo-compare.c and filter-rewriter.c >>>> Report by Coverity and add some comments. >>>> >>>> Signed-off-by: Zhang Chen >>>> Reviewed-by: zhanghailiang >>>> Signed-off-by: Jason Wang >>>> --- >>> Hi, >>> >>> This commit breaks --enable-trace-backends=ust builds in travis (#17): >>> >>> In file included from ./trace/generated-tracers.h:5966:0, >>> from /home/travis/build/gkurz/qemu/include/trace.h:4, >>> from qapi/qapi-visit-core.c:22: >>> ./trace/generated-ust-provider.h:18625:3: error: unknown type name >>> ‘_TP_EXPROTOint’ >>> In file included from >>> /home/travis/build/gkurz/qemu/include/trace.h:4:0, >>> from qapi/qapi-visit-core.c:22: >>> ./trace/generated-tracers.h: In function ‘trace_colo_compare_pkt_info’: >>> ./trace/generated-tracers.h:19249:432: error: expected string >>> literal before ‘_SDT_ASM_OPERANDS_ssize’ >>> ./trace/generated-tracers.h:19249:432: error: implicit declaration >>> of function ‘__tracepoint_cb_qemu___colo_compare_pkt_info’ >>> [-Werror=implicit-function-declaration] >>> ./trace/generated-tracers.h:19249:432: error: nested extern >>> declaration of ‘__tracepoint_cb_qemu___colo_compare_pkt_info’ >>> [-Werror=nested-externs] >>> cc1: all warnings being treated as errors >>> make: *** [qapi/qapi-visit-core.o] Error 1 >>> make: *** Waiting for unfinished jobs.... >>> >>> https://travis-ci.org/gkurz/qemu/jobs/171641119 >> >> I got your point and test it, same problem in here. >> I found that when trace args >10 it not work(this trace have 11 args), >> else it works well like that: >> >> colo_compare_pkt_info(const char *src, const char *dst, uint32_t >> pseq, uint32_t pack, uint32_t sseq, uint32_t sack, int res, uint32_t >> pflag, uint32_t sflag, const char *src1) "src/dst: %s/%s p: >> seq/ack=%u/%u s: seq/ack=%u/%u res=%d flags=%x/%x %s\n" >> >> So I think this bug could be related to trace system, but I review >> trace codes nothing be found about this. >> CC: stefan >> >> Thanks > > We met similar issue in the past which looks like a limitation of the > backend. > > Btw, Alex Bennee has posted a workaround for this, could you please > review or ack on that patch? Can you give me a patch name ? and about this patch, should I send a patch split this trace_event to two trace_event first ? Thanks Zhang Chen > > Thanks > > > . > -- Thanks zhangchen