From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnPBG-00063W-7c for qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:06:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnPBA-0005G6-Ir for qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:06:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53030) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dnPBA-0005Fi-CK for qemu-devel@nongnu.org; Thu, 31 Aug 2017 09:06:40 -0400 References: <20170830170601.15855-1-david@redhat.com> <20170830170601.15855-2-david@redhat.com> From: David Hildenbrand Message-ID: <8dfd227b-1b56-4db3-4b13-1eb00602e627@redhat.com> Date: Thu, 31 Aug 2017 15:06:36 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 01/11] exec, dump: don't include exec/exec-all.h explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: Richard Henderson , Aurelien Jarno , cohuck@redhat.com, borntraeger@de.ibm.com, Alexander Graf On 30.08.2017 20:55, Thomas Huth wrote: > On 30.08.2017 19:05, David Hildenbrand wrote: >> All but two, namely exec.c and dump.c, include exec/exec-all.h via >> cpu.h only. as these files already include cpu.h, let's just drop the >> additional include. >> >> Signed-off-by: David Hildenbrand >> --- >> dump.c | 1 - >> exec.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/dump.c b/dump.c >> index d9090a24cc..c00094475c 100644 >> --- a/dump.c >> +++ b/dump.c >> @@ -15,7 +15,6 @@ >> #include "qemu/cutils.h" >> #include "elf.h" >> #include "cpu.h" >> -#include "exec/cpu-all.h" > > That's cpu-all.h, not exec-all.h ... > >> #include "exec/hwaddr.h" >> #include "monitor/monitor.h" >> #include "sysemu/kvm.h" >> diff --git a/exec.c b/exec.c >> index d20c34ca83..8d8b6a0769 100644 >> --- a/exec.c >> +++ b/exec.c >> @@ -23,7 +23,6 @@ >> >> #include "qemu/cutils.h" >> #include "cpu.h" >> -#include "exec/exec-all.h" >> #include "exec/target_page.h" >> #include "tcg.h" >> #include "hw/qdev-core.h" > > ... and if I do a grep for exec-all.h in the cpu.h files, I hardly get > any matches. => Your patch description sounds wrong ... I guess you only > wanted to handle cpu-all.h here? > > Thomas > exec/cpu-all.h it is. Fixed the subject+description. I'd really love to know what my brain was doing while composing that message. It will remain a mystery. -- Thanks, David