From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Ani Sinha <ani@anisinha.ca>, BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [PATCH 4/5] hw/isa/Kconfig: Add missing dependency to VT82C686
Date: Mon, 12 Dec 2022 11:37:12 +0100 [thread overview]
Message-ID: <8e05d6fa-1792-bb7d-cbf3-ce3a96e64e45@linaro.org> (raw)
In-Reply-To: <20221207231205.1106381-5-shentey@gmail.com>
On 8/12/22 00:12, Bernhard Beschow wrote:
> Both ACPI_PIIX4 (directly) and ACPI_ICH9 (indirectly) require ACPI to be
> selected. Require it for VT82C686's ACPI controller too for consistency.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> hw/isa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 0a6a04947c..bc2e3ecf02 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -63,6 +63,7 @@ config VT82C686
> select IDE_VIA
> select MC146818RTC
> select PARALLEL
> + depends on ACPI
The VT82C686 *provides* the ACPI interface, so here we want to "select"
ACPI (if we need a VT82C686, then ACPI will be available).
next prev parent reply other threads:[~2022-12-12 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 23:12 [PATCH 0/5] Clean up dependencies of ACPI controllers Bernhard Beschow
2022-12-07 23:12 ` [PATCH 1/5] hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4 Bernhard Beschow
2022-12-07 23:12 ` [PATCH 2/5] hw/acpi/Kconfig: Rename ACPI_X86_ICH to ACPI_ICH9 Bernhard Beschow
2022-12-08 6:50 ` Philippe Mathieu-Daudé
2022-12-07 23:12 ` [PATCH 3/5] hw/acpi/Kconfig: Add missing dependencies " Bernhard Beschow
2022-12-12 10:33 ` Philippe Mathieu-Daudé
2022-12-07 23:12 ` [PATCH 4/5] hw/isa/Kconfig: Add missing dependency to VT82C686 Bernhard Beschow
2022-12-12 10:37 ` Philippe Mathieu-Daudé [this message]
2022-12-12 15:54 ` Bernhard Beschow
2022-12-07 23:12 ` [PATCH 5/5] hw/ppc/Kconfig: Remove unused dependencies from PEGASOS2 Bernhard Beschow
2022-12-12 10:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e05d6fa-1792-bb7d-cbf3-ce3a96e64e45@linaro.org \
--to=philmd@linaro.org \
--cc=ani@anisinha.ca \
--cc=balaton@eik.bme.hu \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).