From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g86Hv-0003ym-7d for qemu-devel@nongnu.org; Thu, 04 Oct 2018 12:15:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g86Hr-0006Zh-Tr for qemu-devel@nongnu.org; Thu, 04 Oct 2018 12:15:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39020) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g86Hr-0006Ye-Ij for qemu-devel@nongnu.org; Thu, 04 Oct 2018 12:15:39 -0400 References: <1538164055-23719-1-git-send-email-wei@redhat.com> <20181004134834.bvvovxyjvyjitkrk@kamzik.brq.redhat.com> <8ce54a31-61e7-b3e7-acd9-64b3316791ad@redhat.com> From: Wei Huang Message-ID: <8e18a83d-6e11-a569-d47f-caa72566ea1c@redhat.com> Date: Thu, 4 Oct 2018 11:15:34 -0500 MIME-Version: 1.0 In-Reply-To: <8ce54a31-61e7-b3e7-acd9-64b3316791ad@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Andrew Jones Cc: lvivier@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com On 10/04/2018 09:17 AM, Thomas Huth wrote: > On 2018-10-04 15:48, Andrew Jones wrote: >> On Fri, Sep 28, 2018 at 03:47:35PM -0400, Wei Huang wrote: > [...] >>> diff --git a/tests/migration/aarch64/Makefile b/tests/migration/aarch64/Makefile >>> new file mode 100644 >>> index 0000000..d440fa8 >>> --- /dev/null >>> +++ b/tests/migration/aarch64/Makefile >>> @@ -0,0 +1,20 @@ >>> +# To specify cross compiler prefix, use CROSS_PREFIX= >>> +# $ make CROSS_PREFIX=aarch64-linux-gnu- >>> + >>> +.PHONY: all clean >>> +all: a-b-kernel.h >>> + >>> +a-b-kernel.h: aarch64.kernel >>> + echo "$$__note" > header.tmp >>> + xxd -i $< | sed -e 's/.*int.*//' >> header.tmp >>> + mv header.tmp $@ >>> + >>> +aarch64.kernel: aarch64.elf >>> + $(CROSS_PREFIX)objcopy -O binary $< $@ >>> + >>> +aarch64.elf: a-b-kernel.S >>> + $(CROSS_PREFIX)gcc -o $@ -nostdlib -Wl,--build-id=none $< >>> + >>> +clean: >>> + @rm -rf *.kernel *.elf >> >> I don't think we need/want '-f'. Why not use $(RM)? > > Does $(RM) work now in the QEMU Makefiles? AFAIK we are disabling the > standard variables in rules.mak ("MAKEFLAGS += -rR"), but never set RM > again... This Makefile isn't part of QEMU regular build process (as Juan pointed it out before: most people won't run/care it unless they want to change the aarch64 migration test case themselves). So rules.mak isn't included. As a result, $(RM) is still available. I just sent in a V2 version to address Philippe's comments, in which I fix @rm anyway. PS: No cover letter to show V1->V2 difference as it is a very straightforward. > > Thomas >