From: Paolo Bonzini <pbonzini@redhat.com>
To: Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev()
Date: Fri, 18 Nov 2016 12:10:36 +0100 [thread overview]
Message-ID: <8e40d25e-f5b7-4853-bcc8-555968360f1a@redhat.com> (raw)
In-Reply-To: <w51a8cxf75m.fsf@maestria.local.igalia.com>
On 18/11/2016 10:51, Alberto Garcia wrote:
>
>>> >> Honestly I don't see the point. It seems easier, more practical and
>>> >> more effective to convert bdrv_aio_* to byte ranges, especially since
>>> >> QED would be basically a rewrite.
>> >
>> > Well, it's an RFC for a reason, I want people to give their opinions
>> > before consistently following through with this. But I do think that
>> > we pointlessly offer too many different interfaces to do the same
>> > thing in the block layer.
> I cannot speak much about the AIO/coroutine interfaces (why do we have
> both? is the latter supposed to supersede the former? I'd appreciate
> some background here) but I did find the code easier to follow after
> these patches, so from that point of view the series looks good to me.
If you like it, who am I to say no! :)
Paolo
next prev parent reply other threads:[~2016-11-18 11:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 17:19 [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev() Kevin Wolf
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 1/8] coroutine: Introduce qemu_coroutine_enter_if_inactive() Kevin Wolf
2016-11-10 23:49 ` Eric Blake
2016-11-17 9:30 ` Alberto Garcia
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments Kevin Wolf
2016-11-10 23:52 ` Eric Blake
2016-11-11 9:58 ` Paolo Bonzini
2016-11-11 14:18 ` Alberto Garcia
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 3/8] quorum: Implement .bdrv_co_readv/writev Kevin Wolf
2016-11-11 1:56 ` Eric Blake
2016-11-16 15:57 ` Alberto Garcia
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 4/8] quorum: Do cleanup in caller coroutine Kevin Wolf
2016-11-11 2:18 ` Eric Blake
2016-11-17 10:04 ` Alberto Garcia
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 5/8] quorum: Inline quorum_aio_cb() Kevin Wolf
2016-11-17 14:25 ` Alberto Garcia
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites Kevin Wolf
2016-11-11 2:25 ` Eric Blake
2016-11-17 14:54 ` Alberto Garcia
2016-11-18 12:21 ` Kevin Wolf
2016-11-18 12:33 ` Alberto Garcia
2016-11-18 21:11 ` Eric Blake
2016-11-21 11:56 ` Kevin Wolf
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev() Kevin Wolf
2016-11-11 2:37 ` Eric Blake
2016-11-11 9:58 ` Kevin Wolf
2016-11-11 15:08 ` Eric Blake
2016-11-17 15:30 ` Alberto Garcia
2016-11-10 17:19 ` [Qemu-devel] [RFC PATCH 8/8] quorum: Inline quorum_fifo_aio_cb() Kevin Wolf
2016-11-18 9:47 ` Alberto Garcia
2016-11-11 9:56 ` [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev() Paolo Bonzini
2016-11-11 10:22 ` Kevin Wolf
2016-11-18 9:51 ` Alberto Garcia
2016-11-18 11:10 ` Paolo Bonzini [this message]
2016-11-13 3:18 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e40d25e-f5b7-4853-bcc8-555968360f1a@redhat.com \
--to=pbonzini@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).