From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3BC0C021A0 for ; Wed, 12 Feb 2025 12:57:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tiCIX-00012Z-21; Wed, 12 Feb 2025 07:57:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiCI7-0000uh-PT for qemu-devel@nongnu.org; Wed, 12 Feb 2025 07:56:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiCI4-0006H9-M6 for qemu-devel@nongnu.org; Wed, 12 Feb 2025 07:56:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739364990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ne1BlzP1YQdadKpVDm54zkVw4T40qs/CxXR7/xXJYC8=; b=DbGAKiSp0oj1q2TF6UHqD5RVD0mwkcitHflw4pXPCJ0iy9y3sa9stbke0y3sz28ywiqEw1 accgYiPnW5VtbGe0XN59ZYhVUSZkRqJlO1oZg4hA35HxXIOFa4wXrvnsTz8UatuetwB1wt s8Wl0wG5ED7mX9OBqXQYZ1ueGYe2mRc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-T8co9GbcMsyc9LndREh4MQ-1; Wed, 12 Feb 2025 07:56:29 -0500 X-MC-Unique: T8co9GbcMsyc9LndREh4MQ-1 X-Mimecast-MFC-AGG-ID: T8co9GbcMsyc9LndREh4MQ_1739364988 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38de1668f18so1519746f8f.0 for ; Wed, 12 Feb 2025 04:56:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739364988; x=1739969788; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ne1BlzP1YQdadKpVDm54zkVw4T40qs/CxXR7/xXJYC8=; b=w9LrYB4NKTLdbKVwa+0c79z7kjtkTRAVtjPI+alExUJXBX7npuoIjkLkND0aPoyiXn 1IjEkcdRKpOAgCJrHIdvvE3CaY9jo1rm7DWeyC5b9fJtPlj9Fdip2EB0cNcmWlzLxQHC zB1U2DdqxkuBwolV0zqezPenRmayDTpTcZVjrMUYeZLsXeaVEUFjQHThL42uCyZiu98L KRM7WkJ94wFtlWAn9z5MiTaXVcDM6B8+S6IqpaWJmDWvJWCNxIK/q1R9RUMLEqFz92oJ S4JMujVhHvI6xapx71RB7CXe8F5/3KXgfOhyDHVKKg7cIbrcCvVU9rETNRQf5u9zpygG 3FOw== X-Forwarded-Encrypted: i=1; AJvYcCUgjSOI+Wf+BoelSkInna8NQ4BzuFnVqQUD/DrDXNAVt7GV4wWYHWmlsPbmwUi0Mc9jUJGln2eWCeiY@nongnu.org X-Gm-Message-State: AOJu0YwPhthKHQMgAwLe+/XzWuPjKrLHxa5t0x3kO72/yG1m1DaH8FGj h8tgkTiM3jPDNNB7f/EtUNphx9+7iVDLJCBEOXMatx5Ayg6rFBJg1bSit55LEsfn6phN5TVMSFX YlK0AplqfDaHW1w6UxJsLmB91t1BXntX7IMAVydZLJ5ucrjnW0QeS X-Gm-Gg: ASbGncuv1DuLwZN7s0QS0FA53EoYiMdtBh4gr10UMACuSGJ9GQmoT+e7mVBwACe3Mdk b6L+Q2LMsmYDi/S25BK/zNMMNkvxaGIBrTl2wKw4wJO+640/JUyDuK1opZqdDR0kQQXhueZrNe+ JwmVDtlIXK/p6eEpPJQ95iryv2yptajr4BQ9sbtK+M6uDaDYNU7nDnFY2XxGZXUKKJ1jl0YhccX +2jt28w3KcXoWjtMHepTKdmflFl0c2wwR8irQVjBDNgVchvhUPTSR7P0c074AM6zePZeuf+IGBf 62TX7kHmxvYFBgidXPlSZGp2Af3+2oqyaw== X-Received: by 2002:a5d:47af:0:b0:38d:d4b5:84cf with SMTP id ffacd0b85a97d-38dea256360mr2255267f8f.5.1739364987929; Wed, 12 Feb 2025 04:56:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGG8dIdMEE5MsN7DJWW8Do3vWLYiGtlSvA89uzsUlPIodau+/MPQEKZawN7uF9R28mCZavaYA== X-Received: by 2002:a5d:47af:0:b0:38d:d4b5:84cf with SMTP id ffacd0b85a97d-38dea256360mr2255240f8f.5.1739364987576; Wed, 12 Feb 2025 04:56:27 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-48-37.web.vodafone.de. [109.42.48.37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dd4764880sm11720485f8f.25.2025.02.12.04.56.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Feb 2025 04:56:27 -0800 (PST) Message-ID: <8e5050d7-2792-44af-8317-2dd6948f72c7@redhat.com> Date: Wed, 12 Feb 2025 13:56:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 02/10] hw/intc/xilinx_intc: Make device endianness configurable To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, Sai Pavan Boddu , Markus Armbruster , "Edgar E. Iglesias" , Alistair Francis , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= References: <20250212123659.52764-1-philmd@linaro.org> <20250212123659.52764-3-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250212123659.52764-3-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/02/2025 13.36, Philippe Mathieu-Daudé wrote: > Replace the DEVICE_NATIVE_ENDIAN MemoryRegionOps by a pair > of DEVICE_LITTLE_ENDIAN / DEVICE_BIG_ENDIAN. > Add the "little-endian" property to select the device > endianness, defaulting to little endian. > Set the proper endianness for each machine using the device. > > Signed-off-by: Philippe Mathieu-Daudé > --- ... > diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c > index 8b44be75a22..55398cc67d1 100644 > --- a/hw/microblaze/petalogix_ml605_mmu.c > +++ b/hw/microblaze/petalogix_ml605_mmu.c > @@ -111,6 +111,7 @@ petalogix_ml605_init(MachineState *machine) > > > dev = qdev_new("xlnx.xps-intc"); > + qdev_prop_set_enum(dev, "endianness", ENDIAN_MODE_LITTLE); Do we still need a TARGET_BIG_ENDIAN ?: check here, too? ... the petalogix_ml605_machine_init() code still contains it, though big endian is marked as deprecated and untested ... Anyway, assuming that nobody uses this in big endian anymore: Reviewed-by: Thomas Huth