Re: [PATCH v2 0/1] qemu-nbd: Close inherited stderr

[Eric Blake <eblake@redhat.com>]

On 5/15/20 1:36 AM, Raphael Pour wrote:
>>From e5749541494abcdcaa37d752172741e1bc38e984 Mon Sep 17 00:00:00 2001
> From: Raphael Pour <raphael.pour@hetzner.com>
> Date: Fri, 15 May 2020 08:30:50 +0200
> Subject: [PATCH] qemu-nbd: Close inherited stderr
> 
> Close inherited stderr of the parent if fork_process is false.
> Otherwise no one will close it. (introduced by e6df58a5)
> 
> Signed-off-by: Raphael Pour <raphael.pour@hetzner.com>
> ---
>   qemu-nbd.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

Thanks. It might have been easier posting this as a standalone v3 rather 
than buried in reply to v2, but I have now queued it to go in through my 
NBD tree (I plan on doing a pull request Monday).

I've also taken the liberty to amend the commit message as follows, to 
give more context into why the fix is needed:

     qemu-nbd: Close inherited stderr

     Close inherited stderr of the parent if fork_process is false.
     Otherwise no one will close it. (introduced by e6df58a5)

     This only affected 'qemu-nbd -c /dev/nbd0'.

     Signed-off-by: Raphael Pour <raphael.pour@hetzner.com>
     Message-Id: <d8ddc993-9816-836e-a3de-c6edab9d9c49@hetzner.com>
     Reviewed-by: Eric Blake <eblake@redhat.com>
     [eblake: Enhance commit message]
     Signed-off-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org