From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AAC8C433E0 for ; Wed, 24 Feb 2021 01:40:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91AB564E77 for ; Wed, 24 Feb 2021 01:40:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91AB564E77 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEjAB-0002uw-LN for qemu-devel@archiver.kernel.org; Tue, 23 Feb 2021 20:40:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEj8L-000297-C4 for qemu-devel@nongnu.org; Tue, 23 Feb 2021 20:38:33 -0500 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:37505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEj8J-00081I-VB for qemu-devel@nongnu.org; Tue, 23 Feb 2021 20:38:33 -0500 Received: by mail-pg1-x536.google.com with SMTP id o10so404796pgg.4 for ; Tue, 23 Feb 2021 17:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9P9Uje7yNTMpqc035Yzyg5SVj7YJsp7wrKAUUnCIOek=; b=d4qaZFVq37RAbG6qZhIjKvdk7b8X/GyY5MTD9RkFc4u1PfEPQ++2N/wA3ECI/YL8x6 c+MuT2vMs29jr+l5Km/EjGhUcsS4HyJGekqI1EKNne8ssIGbf0byoUez+KXog5pNw3JQ KQRnI70a0UZNCwhI1uN7AhYWUTNPCI/BWswH3AvdzJgpNdtHhnHHScRqM3MgHTyo3Zbg YkwkI8/ns/NPoQmjZ92YUn/e65O+82K4EHV/9R7cTVrCFs84yR+P13oOMgDz7ChZ2yEb Qmxq5Ej2hOdprW7KIKJXmF6Lsw0tWsYPCGoqtGDzm0o9tKjnYH9LIbhMTZymgHlXMuvE HSuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9P9Uje7yNTMpqc035Yzyg5SVj7YJsp7wrKAUUnCIOek=; b=OwaNX5s2fLyQPKljHXLtewB4K8q5IOastKPbLWUcEwstCPnOHxK2b6ej3itRNjPTLN jPSmLKpnE1dQ7uR2UeTbDMWkl/I0T7zTpN+ae9pOZYMVGwPpG5tyBGDaEQaHBS/KyGMw n4HDWuRGykMiyem0mJ+0JfvDfguLEu8dTeDH61GrDCD/t5yjTdPHavGhNv0yOwcnvo/4 YH2q+ItZqMeeDFIHax7xh97HI8ebfA7TwZbuBPwW4WpSo+PWF5aij6zF1XNtlX1pqLi2 9j7ZvO+btvOxI8RzSDhHUZbKSKklWP9WfFB+47A2uDE4BAbMmwqdB4W7eotUGxBTZ5yv rvrA== X-Gm-Message-State: AOAM53300d/rphVFV/mfJDOdDjxUqu3Su2Ox331Ybm6oRNVVcS2g4AYx F4lLZaIbAs0SUrmgg8GUeu4eRA== X-Google-Smtp-Source: ABdhPJySYZWkuuv18GXzCvH1SBbCR4DelIf9JxzhGlofBzEplOCmxJPpH0G4SZzNkEH7Xco/fquBYA== X-Received: by 2002:a63:44c:: with SMTP id 73mr27531944pge.128.1614130710566; Tue, 23 Feb 2021 17:38:30 -0800 (PST) Received: from [192.168.1.11] (174-21-84-25.tukw.qwest.net. [174.21.84.25]) by smtp.gmail.com with ESMTPSA id z68sm217432pgb.41.2021.02.23.17.38.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Feb 2021 17:38:30 -0800 (PST) Subject: Re: [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase_mxu() proto public To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210222223901.2792336-1-f4bug@amsat.org> <20210222223901.2792336-9-f4bug@amsat.org> From: Richard Henderson Message-ID: <8e6bbe51-eecc-fbb5-0637-5bc527c77bfa@linaro.org> Date: Tue, 23 Feb 2021 17:38:28 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210222223901.2792336-9-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > +#else /* !defined(TARGET_MIPS64) */ > +void mxu_translate_init(void) > +{ > + g_assert_not_reached(); > +} This is suspect, see next patch. The rest of it seems ok. r~