From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwUmI-0006AW-6l for qemu-devel@nongnu.org; Tue, 18 Oct 2016 09:50:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwUmG-0003gS-Q3 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 09:50:01 -0400 References: <20161014154639.GF3482@stefanha-x1.localdomain> <98a190a0-007b-3a83-8b31-f24de6a95335@redhat.com> <61e334e1-bfe5-7907-cad1-a490ec10f8da@kamp.de> <20161018130429.GG4706@noname.str.redhat.com> <20161018133345.GH4706@noname.str.redhat.com> From: Eric Blake Message-ID: <8e833395-889b-3f89-abe5-8cfd5e90a155@redhat.com> Date: Tue, 18 Oct 2016 08:49:53 -0500 MIME-Version: 1.0 In-Reply-To: <20161018133345.GH4706@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2GIASkkEdVIuaRnuP6RsBomgrhxpmH7Jr" Subject: Re: [Qemu-devel] [Qemu-block] block/nfs: Fine grained runtime options in nfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Ashijeet Acharya Cc: Peter Lieven , Stefan Hajnoczi , qemu-block@nongnu.org, jcody@redhat.com, QEMU Developers , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2GIASkkEdVIuaRnuP6RsBomgrhxpmH7Jr From: Eric Blake To: Kevin Wolf , Ashijeet Acharya Cc: Peter Lieven , Stefan Hajnoczi , qemu-block@nongnu.org, jcody@redhat.com, QEMU Developers , Max Reitz Message-ID: <8e833395-889b-3f89-abe5-8cfd5e90a155@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] block/nfs: Fine grained runtime options in nfs References: <20161014154639.GF3482@stefanha-x1.localdomain> <98a190a0-007b-3a83-8b31-f24de6a95335@redhat.com> <61e334e1-bfe5-7907-cad1-a490ec10f8da@kamp.de> <20161018130429.GG4706@noname.str.redhat.com> <20161018133345.GH4706@noname.str.redhat.com> In-Reply-To: <20161018133345.GH4706@noname.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/18/2016 08:33 AM, Kevin Wolf wrote: >> I have successfully converted NFS block driver to use this set of >> runtime opts which I think is the required condition to add >> blockdev-add compatibility later. Also, since I do not have 'port' as >> a runtime option, I can directly add blockdev-add compatibility after >> this through qapi/block-core.json and will not have to go through the >> tricky method we are implementing for NBD and SSH as there will be no >> use of InetSocketAddress. Right? >=20 > Yes, InetSocketAddress is what makes things a bit tricky, and it doesn'= t > seem to be useful with the API we get from libnfs, so just directly > taking a host name should be okay. Then this one should be easier than > SSH. >=20 > Eric, do you agree, or do you think we should take into account that > libnfs might be extended one day to work on any socket? Ideally, we want the valid JSON for ssh to be a subset of the valid JSON for either InetSocketAddress, or for a flat counterpart (what we did for gluster). I kind of like the flat counterpart idea. Yes, that probably means we need to create a new QAPI type (comparable to the existing types, but omitting port), rather than being able to reuse one; but as long as the parameters are spelled the same, backwards-compatibility states that we can later add fields, and that any two structs with identical fields can be merged into one struct without breaking backwards compatibility. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2GIASkkEdVIuaRnuP6RsBomgrhxpmH7Jr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYBiiBAAoJEKeha0olJ0Nqy3gIAJT99Ygsslvq1udtkGdEXQp/ IPid87i6mKG7MRONL0m6+DQLHgKUeO6GzFKLbX8PyxvOxEfkuB/m8hjGerL5ZEwm Mo+kgYcUnFMaZaedhw8SpvlGI1/rSzl78laTc567YHVcf9XpolplZ6m8NuRZ0a9G 6hWIvSt4o5OJRSeZu7gA/9AYFGpKuRY6jVWGzaBtSGr1yn/fyN1Wwpm3F+yKjk97 g8ehFsLwYMD0uco94sBlK3/ZRKVZYM9UcLbGP2fG2Jb1vWTaRayzd5wdYhSRzaL+ YGxM2y/QYNbjb1fIhzzNgNis3h2gAKsadKcGX3DyPvTAuJaE7hvMpS6cUj2Ev64= =9E/n -----END PGP SIGNATURE----- --2GIASkkEdVIuaRnuP6RsBomgrhxpmH7Jr--