* [PATCH] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr
@ 2022-12-21 13:23 Cédric Le Goater
2022-12-21 13:45 ` Philippe Mathieu-Daudé
2022-12-21 16:34 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Cédric Le Goater @ 2022-12-21 13:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Cédric Le Goater, Eduardo Habkost, Marcel Apfelbaum
These globals were moved to MachineClass by commit 71ae9e94d9 ("pc: Move
option_rom_has_mr/rom_file_has_mr globals to MachineClass"). Finish cleanup.
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
include/hw/loader.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/hw/loader.h b/include/hw/loader.h
index 70248e0da7..1384796a4b 100644
--- a/include/hw/loader.h
+++ b/include/hw/loader.h
@@ -251,9 +251,6 @@ void pstrcpy_targphys(const char *name,
hwaddr dest, int buf_size,
const char *source);
-extern bool option_rom_has_mr;
-extern bool rom_file_has_mr;
-
ssize_t rom_add_file(const char *file, const char *fw_dir,
hwaddr addr, int32_t bootindex,
bool option_rom, MemoryRegion *mr, AddressSpace *as);
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr
2022-12-21 13:23 [PATCH] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr Cédric Le Goater
@ 2022-12-21 13:45 ` Philippe Mathieu-Daudé
2022-12-21 16:34 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-12-21 13:45 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel; +Cc: Eduardo Habkost, Marcel Apfelbaum
On 21/12/22 14:23, Cédric Le Goater wrote:
> These globals were moved to MachineClass by commit 71ae9e94d9 ("pc: Move
> option_rom_has_mr/rom_file_has_mr globals to MachineClass"). Finish cleanup.
>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Marcel Apfelbaum <marcel@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> include/hw/loader.h | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr
2022-12-21 13:23 [PATCH] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr Cédric Le Goater
2022-12-21 13:45 ` Philippe Mathieu-Daudé
@ 2022-12-21 16:34 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2022-12-21 16:34 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: Eduardo Habkost, Marcel Apfelbaum, qemu-devel
Cédric Le Goater <clg@kaod.org> writes:
> These globals were moved to MachineClass by commit 71ae9e94d9 ("pc: Move
> option_rom_has_mr/rom_file_has_mr globals to MachineClass"). Finish cleanup.
>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Marcel Apfelbaum <marcel@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-21 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-21 13:23 [PATCH] hw/core/loader: Remove declarations of option_rom_has_mr/rom_file_has_mr Cédric Le Goater
2022-12-21 13:45 ` Philippe Mathieu-Daudé
2022-12-21 16:34 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).