Re: vm-build-haiku.x86_64 failures

[Thomas Huth <thuth@redhat.com>]

On 11/06/2022 02.16, John Snow wrote:
> Hi,
> 
> on today's upstream of b3cd3b5a66f0dddfe3d5ba2bef13cd4f5b89cde9, I am
> seeing failures with the Haiku VM building test:
> 
> FAILED: libqemuutil.a.p/util_cutils.c.o
[...]
> ../src/util/cutils.c: In function 'qemu_init_exec_dir':
> ../src/util/cutils.c:1019:9: error: unknown type name 'image_info';
> did you mean 'g_info'?
>   1019 |         image_info ii;
>        |         ^~~~~~~~~~
>        |         g_info
> ../src/util/cutils.c:1023:16: warning: implicit declaration of
> function 'get_next_image_info' [-Wimplicit-function-declaration]
>   1023 |         while (get_next_image_info(0, &c, &ii) == B_OK) {
>        |                ^~~~~~~~~~~~~~~~~~~
> ../src/util/cutils.c:1023:16: warning: nested extern declaration of
> 'get_next_image_info' [-Wnested-externs]
> ../src/util/cutils.c:1024:19: error: request for member 'type' in
> something not a structure or union
>   1024 |             if (ii.type == B_APP_IMAGE) {
>        |                   ^
> ../src/util/cutils.c:1024:28: error: 'B_APP_IMAGE' undeclared (first
> use in this function)
>   1024 |             if (ii.type == B_APP_IMAGE) {
>        |                            ^~~~~~~~~~~
> ../src/util/cutils.c:1024:28: note: each undeclared identifier is
> reported only once for each function it appears in
> ../src/util/cutils.c:1025:32: error: request for member 'name' in
> something not a structure or union
>   1025 |                 strncpy(buf, ii.name, sizeof(buf));
>        |                                ^

I think this likely has been broken by commit 06680b15b4ee3184b57
("include: move qemu_*_exec_dir() to cutils") ... Marc-André, could you 
maybe have a look?

> I can't seemingly get older versions of QEMU to build right now in
> order to do a bisect, and I can't find a version of the QEMU tree
> where this test actually works.
> 
> Alexander, do you have any information on this test right now?

The Haiku test has been working fine two month ago after it has been 
updated. See commit 63021223ff2d3d ("Update haiku test vm to R1/Beta3").

  Thomas