From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E298EE4993 for ; Tue, 22 Aug 2023 17:05:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYUo4-0003Dq-LO; Tue, 22 Aug 2023 13:04:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYUo3-0003DB-2q for qemu-devel@nongnu.org; Tue, 22 Aug 2023 13:04:39 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYUnz-0002eV-7C for qemu-devel@nongnu.org; Tue, 22 Aug 2023 13:04:38 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bdc19b782aso30925825ad.0 for ; Tue, 22 Aug 2023 10:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692723873; x=1693328673; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zl/lidmx8ZgQxrNOctprKvX240HkROL8X73axlKfoRQ=; b=thjZ5M5oZG+P5e1yoGwCTk4oMRzXuhVP6Vdrt4+ynsDt4v0HI392e3VpN7N+aK0A7S QEk2otZ6m0RJnhO/rsIQRQlk7qNhvbarv4YVFi4Hzojfltoa/WDyQi9Dhw29U7syh4Gi VktlgGUsR+I2GybOttHJ3dBWd3fKIriF2vkfQHhZCcXTe6y1LrPzgOoGnjHCpC8A1Qa7 +9rVXE/BKaQdfn6AiLXBKM5PEpn/ESLh80MOAdzn11K3oZ9hwZaNSof1PTrCzgIiPCFo rteZ/u78b3UVM6PxWltx5c5kROEOD+itpkmMUmQrb16mFu2wURgjfbgNwxU2Or3rU6Lf jdgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692723873; x=1693328673; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zl/lidmx8ZgQxrNOctprKvX240HkROL8X73axlKfoRQ=; b=T1/HftzfYRgwVNk0MHrMoG46X6dYCELoWdDJ1gM4z7wm/B9zde9H+rA3ZCpgjFEjXV mSElzkPwkULxFr/uITowa5BwPQcPe2c4fd/ajFljF/ZNMtV2JBqQCMDJ7CgpmcTXxZA5 muZwZ8Bn1pKyMQXWjVAAM6rZYy2Yy3U9HYjZCxGTq0Yt3YVVlPKUQfedQf0a+Iill9wt fBjb/M1YfZqHDPGY+bFP+1TzExzsmxSAW0jUseVUEwL94Y8jw3GqJQMtJkwq5Lprz3Rn 1hYLk5B+II8cibWoAs6WLe1J0nigSvI6TMX9KOUyAE8M5EO9VJkjtoca3eHTHiPEpIJP WdBA== X-Gm-Message-State: AOJu0Yxlcfi+78iIYJ5Gcrrfv4mb8AgHTA9Wb0loYk6b0jC10nzVp8UR YyzV28lwQkBxSsBJo5rVPFhcag== X-Google-Smtp-Source: AGHT+IGkPZXk4pExMhe9ebJGWSsuzBt3PckVjjQ3lffElGRip5PfpUGCudWxqQCHOWrMGMBBJ1VQzQ== X-Received: by 2002:a17:903:441:b0:1bf:34fb:3085 with SMTP id iw1-20020a170903044100b001bf34fb3085mr7451570plb.14.1692723873592; Tue, 22 Aug 2023 10:04:33 -0700 (PDT) Received: from ?IPV6:2602:47:d483:7301:4e3c:f4a4:b92a:b5ab? ([2602:47:d483:7301:4e3c:f4a4:b92a:b5ab]) by smtp.gmail.com with ESMTPSA id iy3-20020a170903130300b001b9de39905asm9284878plb.59.2023.08.22.10.04.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 10:04:33 -0700 (PDT) Message-ID: <8ea436d6-029e-20c6-9558-780430ff664d@linaro.org> Date: Tue, 22 Aug 2023 10:04:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 11/12] target/loongarch: Use generic hrev64_i32() in REVB.2H opcode Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Song Gao , "Edgar E. Iglesias" , Greg Kurz , Aurelien Jarno , qemu-ppc@nongnu.org, Peter Maydell , Daniel Henrique Barboza , Aleksandar Rikalo , Paolo Bonzini , David Gibson , Jiaxun Yang , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Yoshinori Sato , Nicholas Piggin , Xiaojuan Yang , qemu-arm@nongnu.org References: <20230822124042.54739-1-philmd@linaro.org> <20230822125221.55046-1-philmd@linaro.org> <1ea2097b-fb72-29c4-622a-79f96f69c2c1@linaro.org> <9ad24cdc-adf4-0a38-9362-e46c559fae7d@linaro.org> From: Richard Henderson In-Reply-To: <9ad24cdc-adf4-0a38-9362-e46c559fae7d@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.767, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/22/23 09:11, Philippe Mathieu-Daudé wrote: >>> -static void gen_revb_2h(TCGv dest, TCGv src1) >>> -{ >>> -    TCGv mask = tcg_constant_tl(0x00FF00FF); >>> -    TCGv t0 = tcg_temp_new(); >>> -    TCGv t1 = tcg_temp_new(); >>> - >>> -    tcg_gen_shri_tl(t0, src1, 8); >>> -    tcg_gen_and_tl(t0, t0, mask); >>> -    tcg_gen_and_tl(t1, src1, mask); >>> -    tcg_gen_shli_tl(t1, t1, 8); > > Looking at > https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#_revb_2h4h2wd > the sign extension is missing, so the next line: > >>> -    tcg_gen_or_tl(dest, t0, t1); > > should be replaced by smth like: > >         tcg_gen_or_tl(t0, t0, t1); >         tcg_gen_ext32s_tl(dest, t0); Extension is handled by TRANS(revb_2h, gen_rr, EXT_NONE, EXT_SIGN, gen_revb_2h) ^^^^^^^^^ this r~