From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, laurent@vivier.eu,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v6 18/19] linux-user/s390x: Add vdso
Date: Fri, 6 Oct 2023 09:30:05 +0200 [thread overview]
Message-ID: <8ecd7fb8-c107-2116-628b-0a5ab7ba37f6@redhat.com> (raw)
In-Reply-To: <3ff69283-ee2a-5feb-6736-93e6f3848e34@linaro.org>
On 05/10/2023 18.14, Philippe Mathieu-Daudé wrote:
> On 4/10/23 01:01, Richard Henderson wrote:
>> On 10/3/23 06:07, Philippe Mathieu-Daudé wrote:
>>>> +++ b/linux-user/s390x/vdso.ld
>>>> @@ -0,0 +1,69 @@
>>>> +/*
>>>> + * Linker script for linux x86-64 replacement vdso.
Should that be s390x instead of x86-64 ?
>>>> + * Copyright 2023 Linaro, Ltd.
>>>> + *
>>>> + * SPDX-License-Identifier: GPL-2.0-or-later
>>>> + */
>>>> +
>>>> +VERSION {
>>>> + LINUX_2.6.29 {
>>>> + global:
>>>> + __kernel_gettimeofday;
>>>> + __kernel_clock_gettime;
>>>> + __kernel_clock_getres;
>>>> + __kernel_getcpu;
>>>> + __kernel_restart_syscall;
>>>
>>> Where is __kernel_restart_syscall defined?
>>
>> It isn't, and I guess isn't needed for qemu (we have QEMU_ERESTARTSYS).
>> I'm not sure why it's an exported symbol for the s390x vdso for the
>> kernel, even if they do require some user-space code.
>>
>> Anyway, I'll remove the symbol here.
>
> OK.
>
> I dare to give:
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> But still I'm Cc'ing David / Thomas who better know s390x :)
Uh, oh, vdso ... I remember some dark magic here on the real kernels on
s390x, involving access registers ... good that we don't need those here :-)
I quickly glanced through the code, and apart from the typo above, it looks
good to me, so:
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-10-06 7:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 2:15 [PATCH v6 00/19] linux-user: Implement VDSOs Richard Henderson
2023-09-30 2:15 ` [PATCH v6 01/19] linux-user: Introduce imgsrc_read, imgsrc_read_alloc Richard Henderson
2023-09-30 2:15 ` [PATCH v6 02/19] linux-user: Tidy loader_exec Richard Henderson
2023-09-30 2:15 ` [PATCH v6 03/19] linux-user: Do not clobber bprm_buf swapping ehdr Richard Henderson
2023-09-30 2:15 ` [PATCH v6 04/19] linux-user: Use ImageSource in load_elf_image Richard Henderson
2023-10-02 13:22 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 05/19] linux-user: Use ImageSource in load_symbols Richard Henderson
2023-09-30 2:15 ` [PATCH v6 06/19] linux-user: Replace bprm->fd with bprm->src.fd Richard Henderson
2023-09-30 2:15 ` [PATCH v6 07/19] linux-user: Load vdso image if available Richard Henderson
2023-10-03 12:47 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 08/19] linux-user: Add gen-vdso tool Richard Henderson
2023-10-03 13:00 ` Philippe Mathieu-Daudé
2023-10-03 23:05 ` Richard Henderson
2023-10-05 16:25 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 09/19] linux-user/i386: Add vdso Richard Henderson
2023-10-05 16:42 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 10/19] linux-user/x86_64: " Richard Henderson
2023-10-05 16:44 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 11/19] linux-user/aarch64: " Richard Henderson
2023-10-05 16:47 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 12/19] linux-user/arm: " Richard Henderson
2023-09-30 2:15 ` [PATCH v6 13/19] linux-user/hppa: " Richard Henderson
2023-10-05 16:16 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 14/19] linux-user/riscv: " Richard Henderson
2023-10-05 16:24 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 15/19] linux-user/loongarch64: " Richard Henderson
2023-10-05 16:18 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 16/19] linux-user/ppc: " Richard Henderson
2023-10-05 16:35 ` Philippe Mathieu-Daudé
2023-09-30 2:15 ` [PATCH v6 17/19] linux-user/s390x: Rename __SIGNAL_FRAMESIZE to STACK_FRAME_OVERHEAD Richard Henderson
2023-09-30 2:15 ` [PATCH v6 18/19] linux-user/s390x: Add vdso Richard Henderson
2023-10-03 13:07 ` Philippe Mathieu-Daudé
2023-10-03 23:01 ` Richard Henderson
2023-10-05 16:14 ` Philippe Mathieu-Daudé
2023-10-06 7:30 ` Thomas Huth [this message]
2023-09-30 2:15 ` [PATCH v6 19/19] build: Add update-linux-vdso makefile rule Richard Henderson
2023-10-03 13:02 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ecd7fb8-c107-2116-628b-0a5ab7ba37f6@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=david@redhat.com \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).