From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBC86C25B75 for ; Mon, 3 Jun 2024 14:56:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sE95X-0002j9-Mc; Mon, 03 Jun 2024 10:55:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE95U-0002im-Nh for qemu-devel@nongnu.org; Mon, 03 Jun 2024 10:55:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE95R-0001B1-UU for qemu-devel@nongnu.org; Mon, 03 Jun 2024 10:55:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717426499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f1dL9b4MzQ/NsMcjkHzIehxrRoW4i6pihd1vUuZuQWw=; b=RprK+DV2Zv2UO5s6A0ux3SOa727HF7+2rmB2o+73UmeJrOsOKrqdN3MV7umNBP3O5IQxQR DLYbFvOhtyVxcW5UNd8sg3jjaeatZ5O7LXr4gGGu0AK/KuuuyQA05ls+RW80iTiwm8zLuL 9s2htPNofYbXcR/fSVFml+vHkE/hddI= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-5FKRRsHyM56NfbK8f_Yijg-1; Mon, 03 Jun 2024 10:54:58 -0400 X-MC-Unique: 5FKRRsHyM56NfbK8f_Yijg-1 Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-6f121bff99aso4841004a34.3 for ; Mon, 03 Jun 2024 07:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717426497; x=1718031297; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f1dL9b4MzQ/NsMcjkHzIehxrRoW4i6pihd1vUuZuQWw=; b=tsIl/sRrAb26lr8XjupmVpo65hXFa7RoXMcMgEhQdTjYMlUYusrENbNP2bTCV5HAJp ecPAvXzhB3Vkczl58aFZJGLq4NiYTIHuyzejBJVQYB1phhR+5vDU5/RsbaCNrw8Bb/8Y UAoTyykqRjd6RjSt0A8pn9L+mjfIXGVrBu1fxmd60UGp6o0895EKwOajDLZIiXRR8593 G0tz3o+0yicLHHUrmwED5WJyDRm7fGdevJ74mn/AMypm6FLNMQ6L49sivIDPJk8P1QvR LvE31W6GIaLRgCZ0k/CRUp+Wj76psMJ2B0sxeJ8sM++kmCA3glZrFsZuWJPj1OUU6gs+ gCCQ== X-Forwarded-Encrypted: i=1; AJvYcCWQnH6nDaO4WKTgd7LVrUxFWQ1isId7jmMl3+d6KTHXtIVxGN4qr933Bf6o4+iiqLN5AhGX0JDT8Ekkzd5yhN8Dl6uOF6o= X-Gm-Message-State: AOJu0YyfPS5RQ2rcNRCXagQSQVf0Dawz/ImnKdvWzqQJIyo8i4Vrwi+v tBymMzgKVuPuK+StSTKFKTzSh5SX1TOqnwpabViSn36LH4mpeuMsrUyeX4IpFco2es703x5Hi7+ 6DXhBO0/MIPg1Ax8qeMbf3s2aMaNp2p8HtTSyh9EvkjiiDHEQPCtzVFgA7tNk X-Received: by 2002:a05:6870:fba1:b0:250:75ec:fe99 with SMTP id 586e51a60fabf-2508baad409mr10592769fac.32.1717426497316; Mon, 03 Jun 2024 07:54:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7j6pK4meKsEoBnKxsk4R3/Su7rxg186ngEWs83XgksUAGlUMe4XMdcBN4oHTq7Ydcmb8pDw== X-Received: by 2002:a05:6870:fba1:b0:250:75ec:fe99 with SMTP id 586e51a60fabf-2508baad409mr10592748fac.32.1717426496949; Mon, 03 Jun 2024 07:54:56 -0700 (PDT) Received: from [192.168.0.4] (ip-109-43-176-229.web.vodafone.de. [109.43.176.229]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6af39fd96d7sm20245656d6.138.2024.06.03.07.54.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 07:54:56 -0700 (PDT) Message-ID: <8eda01d5-9f6e-4785-bf70-e4d869ab02a6@redhat.com> Date: Mon, 3 Jun 2024 16:54:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] update-linux-headers: fix forwarding to asm-generic headers To: Paolo Bonzini , qemu-devel@nongnu.org Cc: cohuck@redhat.com References: <20240603131141.834241-1-pbonzini@redhat.com> <20240603131141.834241-2-pbonzini@redhat.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240603131141.834241-2-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 03/06/2024 15.11, Paolo Bonzini wrote: > Afer commit 3efc75ad9d9 ("scripts/update-linux-headers.sh: Remove > temporary directory inbetween", 2024-05-29), updating linux-headers/ > results in errors such as > > cp: cannot stat '/tmp/tmp.1A1Eejh1UE/headers/include/asm/bitsperlong.h': No such file or directory Oops, sorry, I was pretty sure the update was working for me when I tested the patch ... maybe I was on an older branch that didn't have loongarch support yet. > diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh > index 23afe8c08ad..ae34d18572b 100755 > --- a/scripts/update-linux-headers.sh > +++ b/scripts/update-linux-headers.sh > @@ -118,7 +118,14 @@ for arch in $ARCHLIST; do > rm -rf "$output/linux-headers/asm-$arch" > mkdir -p "$output/linux-headers/asm-$arch" > for header in kvm.h unistd.h bitsperlong.h mman.h; do > - cp "$hdrdir/include/asm/$header" "$output/linux-headers/asm-$arch" > + if test -f "$hdrdir/include/asm/$header"; then > + cp "$hdrdir/include/asm/$header" "$output/linux-headers/asm-$arch" > + elif test -f "$hdrdir/include/asm-generic/$header"; then > + # not installed as , but used as such in kernel sources Maybe change the comment to talk about instead of ? > + cat <$output/linux-headers/asm-$arch/$header > +#include > +EOF > + fi > done > > if [ $arch = mips ]; then Reviewed-by: Thomas Huth