Re: [PATCH v2 17/20] iotests: Give access to the qemu-storage-daemon

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1176 bytes --]

On 15.10.20 13:27, Kevin Wolf wrote:
> Am 22.09.2020 um 12:49 hat Max Reitz geschrieben:
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>  tests/qemu-iotests/check     | 11 +++++++++++
>>  tests/qemu-iotests/common.rc | 17 +++++++++++++++++
>>  2 files changed, 28 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
>> index e14a1f354d..467a7cf1b7 100755
>> --- a/tests/qemu-iotests/check
>> +++ b/tests/qemu-iotests/check
>> @@ -644,6 +644,17 @@ if [ -z $QEMU_NBD_PROG ]; then
>>  fi
>>  export QEMU_NBD_PROG="$(type -p "$QEMU_NBD_PROG")"
>>  
>> +if [ -z "$QEMU_STGD_PROG" ]; then
> 
> No series without some bikeshedding:
> 
> This is the first time I see "QEMU_STGD" as a short form. Without the
> subject line of the patch, I wouldn't be able to guess what it is.
> 
> If the full name ($QEMU_STORAGE_DAEMON_PROG) is too long, I think simply
> $QSD_PROG would be an alternative, because "qsd" is what people already
> use an as abbreviation.

I asked myself for a second what this QEMU Street Day you’re referring
to is (I blame the [k] at the beginning of both ?SDs), but sure, why not.

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]