From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Bin Meng <bmeng.cn@gmail.com>,
qemu-block@nongnu.org,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH 4/8] hw/sd/sdcard: Refactor sd_bootpart_offset
Date: Mon, 25 Aug 2025 11:41:34 +0200 [thread overview]
Message-ID: <8f04ee1f-1806-40a1-aa8f-0bb7ca634b98@linaro.org> (raw)
In-Reply-To: <ed81074b51bd85d51930424ed0e9ff24654a95c1.1756019920.git.jan.kiszka@siemens.com>
On 24/8/25 09:18, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This function provides the offset for any partition in the block image,
> not only the boot partitions, therefore rename it. Align the constant
> names with the numbering scheme in the standard and use constants for
> both boot partitions for consistency reasons. There is also no reason to
> return early if boot_part_size is zero because the existing code will
> provide the right value in that case as well.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/sd/sd.c | 16 ++++++++--------
> hw/sd/sdmmc-internal.h | 3 ++-
> 2 files changed, 10 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-08-25 9:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 7:18 [PATCH 0/8] sd: Add RPMB emulation to eMMC model Jan Kiszka
2025-08-24 7:18 ` [PATCH 1/8] hw/sd/sdcard: Fix size check for backing block image Jan Kiszka
2025-08-25 9:39 ` Philippe Mathieu-Daudé
2025-08-24 7:18 ` [PATCH 2/8] hw/sd/sdcard: Add validation for boot-partition-size Jan Kiszka
2025-08-24 7:18 ` [PATCH 3/8] hw/sd/sdcard: Allow user-instantiated eMMC Jan Kiszka
2025-08-24 7:18 ` [PATCH 4/8] hw/sd/sdcard: Refactor sd_bootpart_offset Jan Kiszka
2025-08-25 9:41 ` Philippe Mathieu-Daudé [this message]
2025-08-24 7:18 ` [PATCH 5/8] hw/sd/sdcard: Add basic support for RPMB partition Jan Kiszka
2025-08-24 7:18 ` [PATCH 6/8] crypto/hmac: Allow to build hmac over multiple qcrypto_gnutls_hmac_bytes[v] calls Jan Kiszka
2025-08-25 9:43 ` Philippe Mathieu-Daudé
2025-08-24 7:18 ` [PATCH 7/8] hw/sd/sdcard: Handle RPMB MAC field Jan Kiszka
2025-08-25 9:47 ` Philippe Mathieu-Daudé
2025-08-25 16:12 ` Jan Kiszka
2025-08-25 16:30 ` Philippe Mathieu-Daudé
2025-08-26 10:18 ` Daniel P. Berrangé
2025-08-27 5:53 ` Jan Kiszka
2025-08-27 9:53 ` Daniel P. Berrangé
2025-09-09 14:39 ` Jerome Forissier
2025-08-24 7:18 ` [PATCH 8/8] scripts: Add helper script to generate eMMC block device images Jan Kiszka
2025-08-25 9:51 ` Philippe Mathieu-Daudé
2025-09-09 14:25 ` Jerome Forissier
2025-09-14 12:23 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f04ee1f-1806-40a1-aa8f-0bb7ca634b98@linaro.org \
--to=philmd@linaro.org \
--cc=bmeng.cn@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).