qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: riku.voipio@iki.fi
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH 7/7] linux-user/syscall.c: Enforce pselect6 sigset size restrictions
Date: Mon, 11 Jul 2011 17:11:02 +0300	[thread overview]
Message-ID: <8f04eeb3c094bf370f131e50b7e3da85d08d518f.1310392747.git.riku.voipio@linaro.org> (raw)
In-Reply-To: <cover.1310392747.git.riku.voipio@linaro.org>

From: Peter Maydell <peter.maydell@linaro.org>

Enforce the same restriction on the size of the sigset passed to
pselect6 as the Linux kernel does. This is both correct and silences
a gcc 4.6 warning about a write-only variable.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 linux-user/syscall.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index e2f356b..90f6789 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5699,6 +5699,11 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
 
                 if (arg_sigset) {
                     sig.set = &set;
+                    if (arg_sigsize != sizeof(*target_sigset)) {
+                        /* Like the kernel, we enforce correct size sigsets */
+                        ret = -TARGET_EINVAL;
+                        goto fail;
+                    }
                     target_sigset = lock_user(VERIFY_READ, arg_sigset,
                                               sizeof(*target_sigset), 1);
                     if (!target_sigset) {
-- 
1.7.4.1

      parent reply	other threads:[~2011-07-11 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 14:10 [Qemu-devel] [PATCH 0/7] pending linux-user patches riku.voipio
2011-07-11 14:10 ` [Qemu-devel] [PATCH 1/7] arm-semi: Provide access to CLI arguments passed through the "-append" option riku.voipio
2011-07-11 14:10 ` [Qemu-devel] [PATCH 2/7] linux-user: Add support for KD...LED ioctls riku.voipio
2011-07-11 14:10 ` [Qemu-devel] [PATCH 3/7] linux-user: Add support for more VT ioctls riku.voipio
2011-07-11 14:10 ` [Qemu-devel] [PATCH 4/7] linux-user: Add support for even more FB ioctls riku.voipio
2011-07-11 14:11 ` [Qemu-devel] [PATCH 5/7] linux-user: Add syscall numbers from kernel 2.6.39.2 riku.voipio
2011-07-11 15:12   ` cedric.vincent
2011-07-11 14:11 ` [Qemu-devel] [PATCH 6/7] linux-user: Implement prlimit64 syscall riku.voipio
2011-07-11 14:11 ` riku.voipio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f04eeb3c094bf370f131e50b7e3da85d08d518f.1310392747.git.riku.voipio@linaro.org \
    --to=riku.voipio@iki.fi \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).