From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgHCn-0005hE-5o for qemu-devel@nongnu.org; Mon, 11 Jul 2011 10:11:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgHCl-0000sb-FC for qemu-devel@nongnu.org; Mon, 11 Jul 2011 10:11:24 -0400 Received: from afflict.kos.to ([92.243.29.197]:37513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgHCk-0000sK-MX for qemu-devel@nongnu.org; Mon, 11 Jul 2011 10:11:22 -0400 From: riku.voipio@iki.fi Date: Mon, 11 Jul 2011 17:11:02 +0300 Message-Id: <8f04eeb3c094bf370f131e50b7e3da85d08d518f.1310392747.git.riku.voipio@linaro.org> In-Reply-To: References: Subject: [Qemu-devel] [PATCH 7/7] linux-user/syscall.c: Enforce pselect6 sigset size restrictions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell From: Peter Maydell Enforce the same restriction on the size of the sigset passed to pselect6 as the Linux kernel does. This is both correct and silences a gcc 4.6 warning about a write-only variable. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e2f356b..90f6789 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5699,6 +5699,11 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, if (arg_sigset) { sig.set = &set; + if (arg_sigsize != sizeof(*target_sigset)) { + /* Like the kernel, we enforce correct size sigsets */ + ret = -TARGET_EINVAL; + goto fail; + } target_sigset = lock_user(VERIFY_READ, arg_sigset, sizeof(*target_sigset), 1); if (!target_sigset) { -- 1.7.4.1