From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-io: Fix missing getopt() updates
Date: Fri, 13 May 2016 13:55:41 +0200 [thread overview]
Message-ID: <8f201740-1e57-870c-77d9-42a3dc1f2275@redhat.com> (raw)
In-Reply-To: <1463089170-30550-2-git-send-email-eblake@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On 12.05.2016 23:39, Eric Blake wrote:
> Commit 770e0e0e [*] forgot to implement 'writev -f'. Likewise,
> commit c3e001c forgot to implement 'aio_write -u -z'.
*c2e001c
I can fix that while applying, though.
Max
>
> [*] does it sound "ech0e" in here? :)
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> qemu-io-cmds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index 4a00bc6..415be25 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -1150,7 +1150,7 @@ static int writev_f(BlockBackend *blk, int argc, char **argv)
> int pattern = 0xcd;
> QEMUIOVector qiov;
>
> - while ((c = getopt(argc, argv, "CqP:")) != -1) {
> + while ((c = getopt(argc, argv, "CfqP:")) != -1) {
> switch (c) {
> case 'C':
> Cflag = true;
> @@ -1595,7 +1595,7 @@ static int aio_write_f(BlockBackend *blk, int argc, char **argv)
> int flags = 0;
>
> ctx->blk = blk;
> - while ((c = getopt(argc, argv, "CfqP:z")) != -1) {
> + while ((c = getopt(argc, argv, "CfqP:uz")) != -1) {
> switch (c) {
> case 'C':
> ctx->Cflag = true;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-13 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 21:39 [Qemu-devel] [PATCH 0/3] Fix recent qemu-iotests issues Eric Blake
2016-05-12 21:39 ` [Qemu-devel] [PATCH 1/3] qemu-io: Fix missing getopt() updates Eric Blake
2016-05-13 11:55 ` Max Reitz [this message]
2016-05-13 12:00 ` Max Reitz
2016-05-12 21:39 ` [Qemu-devel] [PATCH 2/3] qemu-iotests: Simplify 109 with unaligned qemu-img compare Eric Blake
2016-05-13 12:00 ` Max Reitz
2016-05-12 21:39 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: Fix regression in 136 on aio_read invalid Eric Blake
2016-05-13 11:59 ` Max Reitz
2016-05-13 12:06 ` [Qemu-devel] [PATCH 0/3] Fix recent qemu-iotests issues Max Reitz
2016-05-13 13:48 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f201740-1e57-870c-77d9-42a3dc1f2275@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).