From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Zhao Liu <zhao1.liu@linux.intel.com>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Yanan Wang <wangyanan55@huawei.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Cc: Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH v3 3/3] hw/core: Cleanup unused included headers in numa.c
Date: Mon, 11 Mar 2024 09:50:03 +0100 [thread overview]
Message-ID: <8f284db9-db08-4eb1-9068-1e7539ae16ba@linaro.org> (raw)
In-Reply-To: <20240311075621.3224684-4-zhao1.liu@linux.intel.com>
On 11/3/24 08:56, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> Remove unused header in numa.c:
> * qemu/bitmap.h
> * migration/vmstate.h
>
> Note: Though parse_numa_hmat_lb() has the variable named "bitmap_copy",
> it doesn't use the normal bitmap ops so that it's safe to exclude
> qemu/bitmap.h header.
>
> Tested by "./configure" and then "make".
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> v3: Re-included hw/core/cpu.h since CPU_UNSET_NUMA_NODE_ID is defined
> in this header.
> ---
> hw/core/numa.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-03-11 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 7:56 [PATCH v3 0/3] hw/core: Cleanup and reorder headers Zhao Liu
2024-03-11 7:56 ` [PATCH v3 1/3] hw/core: Cleanup unused included headers in cpu-common.c Zhao Liu
2024-03-11 11:40 ` Philippe Mathieu-Daudé
2024-03-11 11:44 ` Philippe Mathieu-Daudé
2024-03-11 15:44 ` Zhao Liu
2024-03-11 18:26 ` Philippe Mathieu-Daudé
2024-03-12 2:17 ` Zhao Liu
2024-03-11 7:56 ` [PATCH v3 2/3] hw/core: Cleanup unused included header in machine-qmp-cmds.c Zhao Liu
2024-03-11 8:52 ` Philippe Mathieu-Daudé
2024-03-11 7:56 ` [PATCH v3 3/3] hw/core: Cleanup unused included headers in numa.c Zhao Liu
2024-03-11 8:50 ` Philippe Mathieu-Daudé [this message]
2024-03-11 11:40 ` [PATCH v3 0/3] hw/core: Cleanup and reorder headers Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f284db9-db08-4eb1-9068-1e7539ae16ba@linaro.org \
--to=philmd@linaro.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).