From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E97ACC87FCB for ; Fri, 8 Aug 2025 16:33:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ukQ1k-0002Yz-7n; Fri, 08 Aug 2025 12:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ukQ1i-0002Vi-RH for qemu-devel@nongnu.org; Fri, 08 Aug 2025 12:33:06 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ukQ1f-0004BN-6e for qemu-devel@nongnu.org; Fri, 08 Aug 2025 12:33:05 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-458aee6e86aso14781875e9.3 for ; Fri, 08 Aug 2025 09:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754670781; x=1755275581; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Is/btaog9h8T57V7yZAZzOB7kmb1Hrj+dsZm3eUzTAo=; b=EtOPI1cZhtoTbH+evYWizkC1DbUt4sKWRRXgWEvvz2Y8o1UfwG+iWgnd5pym8mxMk9 4WXzUGlgjh6YYpwvW1TpnGA+jUdXtVeXOIx+Lhd5ad+JKJgVuHZBVuSx/0GdcROkE8pY BxpV9OpCbX82Z/xvWQgZSTKvUcb+YDJrpdiy05AIy1MhZHn8KjWuSrn15DPPbkDBkANX 1V9F6Q20/vInxrc74fGQ0Y/lQZKg78crQtfdU51x0dlFkdkUPF8Jk9yaJEFZR5NFJHNS otzkQXk4lZKUR52feepK8DDu3RyzQHdURrY5s8jBOTkQ4lrhopnXb8kzSibIZdWjTfej ye4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754670781; x=1755275581; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Is/btaog9h8T57V7yZAZzOB7kmb1Hrj+dsZm3eUzTAo=; b=gcdbTQM23D+DVMMKBheCCS3lTJGKbjCSwmwwqVcT/JsZ3Qm7+eRCdiJAIxxmiBLyV6 z4PqPXRYyJ/Dswr8nw9Mq0DCcW7pA/cGOtFNw/vpmFsu3BEcIH8eiEjtqhEAJR36uHF5 vBVzQXww5ryzqSJkhIV3GAujd+JptGdDYm6znuBGx2wHH4g/5RdaWoshVYkyWsGdqkc9 V4vbaglcHQxW6yECZ9LT6jomIDEZRyvvG/dC1kxvFPV3GxqzksI0YEH/JZE1ucqzgXsR tLVHayS9A/BvtOL9tf58m9ejatNvIsneYiD5w00JSAqevNWqNcQJ6JNkFO9mOHlp89UP 7qDA== X-Forwarded-Encrypted: i=1; AJvYcCUhplHf11vXlD1l9FgXTxu/MSe08Y6OU2CeGomkB9me5ideixmKR6YWtDEjymW7yv1ibtJoGYZSJDiW@nongnu.org X-Gm-Message-State: AOJu0YwiQbZz3oTVLGABYPPGcFoAdotrHGdcXxCUDgXxOo2PYRfIU1Fs vbfbanhriWGcxtMJAzz3+b0loBE70WAh+cGLt//pqgOAjRFgrYC5CAS64Cvx4MddyyA= X-Gm-Gg: ASbGncv8o8ptysThYo/hB2rcv+AQn8XuUxkos3zKA/SAUG+7/spam9u8AXvM/P+VovF iMByUeaO/Y7cEUIAaHsWM1oSOHC5xbdSueFQjBc0MPNQV6zdyeJvRm5ljky6fYOWm6VuG9IrVQ3 d0u1my6Tr977PZIPLkhLlXAvB+Jmkj6zSXjXp3/cUO1ZNSvLaWaE9WISKeKqmz43HWR6FJxg6KU 9IKZYYj4UsX9nc4pgwNazOH2xIlqUBL/jiyoIQAcjcyVDXQeCm5r5N8bND0yHo/AFMABXb5yFIz uh0evFNtj8AylbMq+b35Vq2sVMB9cx0t3VrkhOt2xXHhnClZl7C3sjWoxqprUMDquutNIWj/R11 slWyQWCFvIgh4kvk5aOSwqsBmO5YzSCKvH3hzuKJshh8XqDK/RxW+DC8NJs2aBSd+uWnu8CUnaa L5 X-Google-Smtp-Source: AGHT+IHksJpCMyiL77F69qBIG+cDZD3iFhHa6ArtUddJMFv3XF4A3JM2mk6qbwG1+Tj0GngHxUQoBA== X-Received: by 2002:a05:600c:1c21:b0:459:d616:25c5 with SMTP id 5b1f17b1804b1-459f4eb406fmr34250415e9.12.1754670780823; Fri, 08 Aug 2025 09:33:00 -0700 (PDT) Received: from [192.168.69.210] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458bbf91b69sm146991445e9.3.2025.08.08.09.32.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Aug 2025 09:33:00 -0700 (PDT) Message-ID: <8f2db989-df19-4fb3-b58e-151bd175d57e@linaro.org> Date: Fri, 8 Aug 2025 18:32:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 14/14] test/functional: Add test for boston-aia board To: Djordje Todorovic , "qemu-devel@nongnu.org" Cc: "qemu-riscv@nongnu.org" , "cfu@mips.com" , "mst@redhat.com" , "marcel.apfelbaum@gmail.com" , "dbarboza@ventanamicro.com" , Thomas Huth References: <20250717093833.402237-1-djordje.todorovic@htecgroup.com> <20250717093833.402237-15-djordje.todorovic@htecgroup.com> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250717093833.402237-15-djordje.todorovic@htecgroup.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, On 17/7/25 11:38, Djordje Todorovic wrote: > Add functional test for Boston AIA board. The P8700 RISC-V based > CPU by MIPS supports it at the moment. > > Signed-off-by: Chao-ying Fu > Signed-off-by: Djordje Todorovic > --- > tests/functional/meson.build | 1 + > tests/functional/test_riscv64_boston.py | 78 +++++++++++++++++++++++++ > 2 files changed, 79 insertions(+) > create mode 100755 tests/functional/test_riscv64_boston.py > diff --git a/tests/functional/test_riscv64_boston.py b/tests/functional/test_riscv64_boston.py > new file mode 100755 > index 0000000000..eb5dd07b79 > --- /dev/null > +++ b/tests/functional/test_riscv64_boston.py > @@ -0,0 +1,78 @@ > +#!/usr/bin/env python3 > +# > +# Boston board test for RISC-V P8700 processor by MIPS > +# > +# Copyright (c) 2025 MIPS > +# > +# SPDX-License-Identifier: LGPL-2.1-or-later > +# > + > +from qemu_test import QemuSystemTest > + > +class RiscvBostonTest(QemuSystemTest): > + """ > + Test the boston-aia board with P8700 processor > + """ > + > + timeout = 10 > + > + def test_boston_memory_constraints(self): > + """ > + Test that boston-aia board enforces memory size constraints > + """ > + # Test invalid memory size > + self.set_machine('boston-aia') > + self.vm.add_args('-cpu', 'mips-p8700') > + self.vm.add_args('-m', '512M') # Invalid size > + self.vm.add_args('-nographic') > + self.vm.set_qmp_monitor(enabled=False) > + self.vm.launch() > + self.vm.wait() > + > + # Should fail due to invalid memory size > + self.assertEqual(self.vm.exitcode(), 1) > + log = self.vm.get_log() > + self.assertIn("Memory size must be 1GB, 2GB, 3GB, or 4GB", log) > + > + def test_boston_requires_kernel(self): > + """ > + Test that boston-aia board requires a kernel or bios > + """ > + self.set_machine('boston-aia') > + self.vm.add_args('-cpu', 'mips-p8700') > + self.vm.add_args('-m', '1G') # Valid size > + self.vm.add_args('-nographic') > + # No kernel or bios specified > + self.vm.set_qmp_monitor(enabled=False) > + self.vm.launch() > + self.vm.wait() > + > + # Should fail due to missing kernel/bios > + self.assertEqual(self.vm.exitcode(), 1) > + log = self.vm.get_log() > + self.assertIn("Please provide either a -kernel or -bios argument", log) > + > + def test_boston_cpu_count(self): > + """ > + Test various CPU counts for boston-aia board > + """ > + cpu_counts = [1, 2, 4, 8] > + > + for cpus in cpu_counts: > + with self.subTest(cpus=cpus): > + self.set_machine('boston-aia') > + self.vm.add_args('-cpu', 'mips-p8700') > + self.vm.add_args('-smp', str(cpus)) > + self.vm.add_args('-m', '1G') > + self.vm.add_args('-nographic') > + self.vm.set_qmp_monitor(enabled=False) > + self.vm.launch() > + self.vm.wait() > + > + # Board should fail due to missing kernel, not CPU count > + self.assertEqual(self.vm.exitcode(), 1) > + log = self.vm.get_log() > + self.assertIn("Please provide either a -kernel or -bios argument", log) > + > +if __name__ == '__main__': > + QemuSystemTest.main() Thanks for testing these constraints, but can we have guest code actually exercising the code path to the XMIPS instructions? Also code testing powering VPs up/down, to cover CPS, GCR and CPC. Code using the e1000e card would be awesome ;) Thanks, Phil.