qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Checkoway <stephen.checkoway@oberlin.edu>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org,
	Stephen Checkoway <stephen.checkoway@oberlin.edu>
Subject: [Qemu-devel] [PATCH v2 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table
Date: Mon,  8 Apr 2019 22:01:34 -0400	[thread overview]
Message-ID: <8f3c98364902035431d788f058b342b286cc924c.1554774454.git.stephen.checkoway@oberlin.edu> (raw)
In-Reply-To: <cover.1554774454.git.stephen.checkoway@oberlin.edu>

When erasing the chip, use the typical time specified in the CFI table
rather than arbitrarily selecting 5 seconds.

Since the currently unconfigurable value set in the table is 12, this
means a chip erase takes 4096 ms so this isn't a big change in behavior.

Signed-off-by: Stephen Checkoway <stephen.checkoway@oberlin.edu>
---
 hw/block/pflash_cfi02.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index d9087cafff..76c8af4365 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -633,9 +633,9 @@ static void pflash_write(void *opaque, hwaddr offset, uint64_t value,
                 pflash_update(pfl, 0, pfl->total_len);
             }
             set_dq7(pfl, 0x00);
-            /* Let's wait 5 seconds before chip erase is done */
+            /* Wait the time specified at CFI address 0x22. */
             timer_mod(&pfl->timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
-                      (NANOSECONDS_PER_SECOND * 5));
+                      (1ULL << pfl->cfi_table[0x22]) * SCALE_MS);
             break;
         case 0x30:
             /* Sector erase */
-- 
2.20.1 (Apple Git-117)

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Checkoway <stephen.checkoway@oberlin.edu>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stephen Checkoway <stephen.checkoway@oberlin.edu>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table
Date: Mon,  8 Apr 2019 22:01:34 -0400	[thread overview]
Message-ID: <8f3c98364902035431d788f058b342b286cc924c.1554774454.git.stephen.checkoway@oberlin.edu> (raw)
Message-ID: <20190409020134.AqJJFH1Ni0vtlsYI96E-w0-j-AH_0OIH4LS_gIgX3x0@z> (raw)
In-Reply-To: <cover.1554774454.git.stephen.checkoway@oberlin.edu>

When erasing the chip, use the typical time specified in the CFI table
rather than arbitrarily selecting 5 seconds.

Since the currently unconfigurable value set in the table is 12, this
means a chip erase takes 4096 ms so this isn't a big change in behavior.

Signed-off-by: Stephen Checkoway <stephen.checkoway@oberlin.edu>
---
 hw/block/pflash_cfi02.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index d9087cafff..76c8af4365 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -633,9 +633,9 @@ static void pflash_write(void *opaque, hwaddr offset, uint64_t value,
                 pflash_update(pfl, 0, pfl->total_len);
             }
             set_dq7(pfl, 0x00);
-            /* Let's wait 5 seconds before chip erase is done */
+            /* Wait the time specified at CFI address 0x22. */
             timer_mod(&pfl->timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
-                      (NANOSECONDS_PER_SECOND * 5));
+                      (1ULL << pfl->cfi_table[0x22]) * SCALE_MS);
             break;
         case 0x30:
             /* Sector erase */
-- 
2.20.1 (Apple Git-117)



  parent reply	other threads:[~2019-04-09  2:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  2:01 [Qemu-devel] [PATCH v2 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality Stephen Checkoway
2019-04-09  2:01 ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 01/10] block/pflash_cfi02: Add test for supported commands Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 02/10] block/pflash_cfi02: Refactor, NFC intended Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 03/10] block/pflash_cfi02: Fix command address comparison Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 04/10] block/pflash_cfi02: Implement intereleaved flash devices Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 05/10] block/pflash_cfi02: Implement nonuniform sector sizes Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 06/10] block/pflash_cfi02: Fix CFI in autoselect mode Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 07/10] block/pflash_cfi02: Fix reset command not ignored during erase Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 08/10] block/pflash_cfi02: Implement multi-sector erase Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` [Qemu-devel] [PATCH v2 09/10] block/pflash_cfi02: Implement erase suspend/resume Stephen Checkoway
2019-04-09  2:01   ` Stephen Checkoway
2019-04-09  2:01 ` Stephen Checkoway [this message]
2019-04-09  2:01   ` [Qemu-devel] [PATCH v2 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table Stephen Checkoway

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f3c98364902035431d788f058b342b286cc924c.1554774454.git.stephen.checkoway@oberlin.edu \
    --to=stephen.checkoway@oberlin.edu \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).