From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 291B8C433E2 for ; Tue, 1 Sep 2020 17:25:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4AB6207D3 for ; Tue, 1 Sep 2020 17:25:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fsNobBwk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4AB6207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDA2R-00056z-VD for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 13:25:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDA1X-0004VV-11 for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:24:47 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:43855 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDA1S-0007WD-05 for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:24:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598981080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jbl6lH6ysZk3JqnD0GGckML7usGfVtttITiiq11c7iA=; b=fsNobBwkM3c5J71YYqX9uWJwe2uCHU+VDZCRLAuz1BQe7Fz87fNkHNnvU9AdtBWz6th8os mpTbDc8kbSM8ByvOeFOUP6mWWlKeuk8qp6ThOwPI2yGR+3IvkUv73R5r372GbDhgv6/S+F tAglQcKA9TVWCmvCwt00QgwtAgyuvgw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-4xk-nB8-PeicaI2zCEaKAA-1; Tue, 01 Sep 2020 13:24:39 -0400 X-MC-Unique: 4xk-nB8-PeicaI2zCEaKAA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAFD0800468; Tue, 1 Sep 2020 17:24:37 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-188.ams2.redhat.com [10.36.112.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 779177DA3F; Tue, 1 Sep 2020 17:24:33 +0000 (UTC) Subject: Re: [PATCH v3 5/5] pc-bios: s390x: Go into disabled wait when encountering a PGM exception To: Janosch Frank , qemu-devel@nongnu.org References: <20200831150910.317171-1-frankja@linux.ibm.com> <20200831150910.317171-6-frankja@linux.ibm.com> From: Thomas Huth Message-ID: <8f41fbcf-a509-f49d-c0b2-1586cee75f73@redhat.com> Date: Tue, 1 Sep 2020 19:24:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200831150910.317171-6-frankja@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=207.211.31.81; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 02:08:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.13, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 31/08/2020 17.09, Janosch Frank wrote: > Let's setup a PGM PSW, so we won't load 0s when a program exception > happens. Instead we'll load a disabled wait PSW. > > Signed-off-by: Janosch Frank > Reviewed-by: Christian Borntraeger > --- > pc-bios/s390-ccw/start.S | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S > index 939aac3a7c..775b45baeb 100644 > --- a/pc-bios/s390-ccw/start.S > +++ b/pc-bios/s390-ccw/start.S > @@ -44,6 +44,9 @@ done: > larl %r2, external_new_psw > stg %r1, 8(%r2) > mvc 0x1b0(16),0(%r2) > + /* set up a pgm exception disabled wait psw */ > + larl %r2, disabled_wait_psw > + mvc 0x01d0(16), 0(%r2) > j main /* And call C */ > > memsetxc: > Sounds like a good idea. Reviewed-by: Thomas Huth