qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Cole Robinson <crobinso@redhat.com>
Subject: [Qemu-devel] [PATCH v3 5/5] gtk: Use ctrl+alt+q for quit accelerator
Date: Mon, 17 Mar 2014 16:06:27 -0400	[thread overview]
Message-ID: <8f5e52223220b7be0aa7113343def80682a66b1c.1395085847.git.crobinso@redhat.com> (raw)
In-Reply-To: <cover.1395085847.git.crobinso@redhat.com>
In-Reply-To: <cover.1395085847.git.crobinso@redhat.com>

Using the standard ctrl+q makes it too easy to kill the whole VM. Using
ctrl+alt+FOO is consistent with our other accelerators.

https://bugzilla.redhat.com/show_bug.cgi?id=1062393
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
v3:
    Fix building with old gtk2

 ui/gtk.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index 9670567..ab08fe0 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -88,6 +88,7 @@ static inline void gdk_drawable_get_size(GdkWindow *w, gint *ww, gint *wh)
 #define GDK_KEY_2 GDK_2
 #define GDK_KEY_f GDK_f
 #define GDK_KEY_g GDK_g
+#define GDK_KEY_q GDK_q
 #define GDK_KEY_plus GDK_plus
 #define GDK_KEY_minus GDK_minus
 #endif
@@ -1328,7 +1329,7 @@ static GtkWidget *gd_create_menu_machine(GtkDisplayState *s, GtkAccelGroup *acce
     gtk_menu_item_set_accel_path(GTK_MENU_ITEM(s->quit_item),
                                  "<QEMU>/Machine/Quit");
     gtk_accel_map_add_entry("<QEMU>/Machine/Quit",
-                            GDK_KEY_q, GDK_CONTROL_MASK);
+                            GDK_KEY_q, HOTKEY_MODIFIERS);
     gtk_menu_shell_append(GTK_MENU_SHELL(machine_menu), s->quit_item);
 
     return machine_menu;
-- 
1.8.5.3

  parent reply	other threads:[~2014-03-17 20:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 20:06 [Qemu-devel] [PATCH v3 0/5] gtk: Fix deprecation warnings, misc bug fixes Cole Robinson
2014-03-17 20:06 ` [Qemu-devel] [PATCH v3 1/5] configure: Document --with-gtkabi Cole Robinson
2014-03-17 20:06 ` [Qemu-devel] [PATCH v3 2/5] gtk: Don't use deprecated gtk_image_menu_item_new_with_mnemonic Cole Robinson
2014-03-17 20:06 ` [Qemu-devel] [PATCH v3 3/5] gtk: Don't use deprecated vte_terminal_get_adjustment Cole Robinson
2014-03-17 20:06 ` [Qemu-devel] [PATCH v3 4/5] gtk: Remove use of deprecated stock items Cole Robinson
2014-03-17 20:06 ` Cole Robinson [this message]
2014-03-18  7:28 ` [Qemu-devel] [PATCH v3 0/5] gtk: Fix deprecation warnings, misc bug fixes Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f5e52223220b7be0aa7113343def80682a66b1c.1395085847.git.crobinso@redhat.com \
    --to=crobinso@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).