From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] nbd/client.c: Correct trace format string
Date: Fri, 17 Jun 2016 15:24:53 +0200 [thread overview]
Message-ID: <8f698e6d-80db-71d5-93d1-7e4143858cb3@redhat.com> (raw)
In-Reply-To: <1466167331-17063-1-git-send-email-peter.maydell@linaro.org>
On 17/06/2016 14:42, Peter Maydell wrote:
> The trace format string in nbd_send_request uses PRIu16 for
> request->type, but request->type is a uint32_t. This provokes
> compiler warnings on the OSX clang. Use PRIu32 instead.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I didn't catch this when I ran the merge build test for the
> pull request, because I don't have warnings-as-errors enabled
> on the OSX test machine yet.
Thanks, please apply directly if you wish.
Paolo
next prev parent reply other threads:[~2016-06-17 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 12:42 [Qemu-devel] [PATCH] nbd/client.c: Correct trace format string Peter Maydell
2016-06-17 13:24 ` Paolo Bonzini [this message]
2016-06-17 14:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f698e6d-80db-71d5-93d1-7e4143858cb3@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).